Page MenuHomePhabricator
Create Task
Maniphest T426338

Add accessors for WFFunctionCall internals
Closed, ResolvedPublic
Actions

Description

WFFunctionCall exposes function_ and argumentMap_ directly to its consumers (notably WFImplementation.evaluate). The TODO at WFFunctionCall.js:80 calls for proper accessors so internal representation can change without rippling out.

Small ergonomic / encapsulation fix; good first-task material.

Desired behavior/Acceptance criteria

  • Add getFunction() and getArgument(key) / getArguments() accessors to WFFunctionCall.
  • Replace direct function_ / argumentMap_ reads at the call sites in src/transpilation/ with the new accessors.
  • Trailing underscore convention for "private" stays — readers outside the class should use the accessors.
  • All existing tests pass.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from 2026-05-19-223625 to 2026-06-03-020126Jforresteroperations/deployment-chartsmaster+1 -1
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
WFFunctionCall: Two minor follow-ups to 0cf417df2f55cd544c28dd7b74bff1ebf920a15erepos/abstract-wiki/wikifunctions/function-orchestrator!684jforrestert426338-accessors-followupmain
Add accessors for WFFunctionCall internalsrepos/abstract-wiki/wikifunctions/function-orchestrator!683gkm563t426338-accessorsmain
Customize query in GitLab

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.May 14 2026, 4:31 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptMay 14 2026, 4:31 PM

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Jdforrester-WMF mentioned this in T413840: Optimize composition language V2.May 15 2026, 12:46 PM
Jdforrester-WMF triaged this task as Low priority.May 15 2026, 1:40 PM
Jdforrester-WMF moved this task from Incoming to Ready on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.
Gkm563 claimed this task.May 15 2026, 2:28 PM
Gkm563 added a project: RoadToWiki.
nehm_hounga subscribed.May 15 2026, 4:14 PM
nehm_hounga unsubscribed.
nehm_hounga subscribed.
nehm_hounga unsubscribed.
Gkm563 added a comment.May 16 2026, 10:46 AM

I implemented the requested accessors for WFFunctionCall locally and prepared the patch.

While attempting to submit the change, I found that this repository has moved to GitLab and the Gerrit mirror is read-only. I also currently cannot create a merge request because my Wikimedia GitLab account is still pending approval.

Could someone advise the preferred submission workflow for this repository?

Jdforrester-WMF changed the task status from Open to In Progress.May 21 2026, 4:06 PM
Jdforrester-WMF moved this task from Ready to In Engineering on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.
In T426338#11928098, @Gkm563 wrote:

I implemented the requested accessors for WFFunctionCall locally and prepared the patch.

Welcome!

While attempting to submit the change, I found that this repository has moved to GitLab and the Gerrit mirror is read-only. I also currently cannot create a merge request because my Wikimedia GitLab account is still pending approval.

Could someone advise the preferred submission workflow for this repository?

Aha. Sorry about that. Do you know if your GitLab account has now been approved? Did you go through the steps on https://www.mediawiki.org/wiki/GitLab/Workflows/Registering_an_account_on_GitLab ? I've now added you to Trusted-Contributors so it should be automatic. Sorry for the delay.

CodeReviewBot added a project: Patch-For-Review.May 24 2026, 5:16 AM

gkm563 opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/683

Add accessors for WFFunctionCall internals

CodeReviewBot added a comment.May 26 2026, 4:21 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/684

WFFunctionCall: Two minor follow-ups to 0cf417df2f55cd544c28dd7b74bff1ebf920a15e

CodeReviewBot added a comment.May 26 2026, 9:11 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/683

Add accessors for WFFunctionCall internals

Jdforrester-WMF moved this task from In Engineering to Ready to deploy on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.May 26 2026, 9:14 PM

Thank you! This will be deployed to production in the next service deploy.

CodeReviewBot added a comment.May 26 2026, 9:36 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/684

WFFunctionCall: Two minor follow-ups to 0cf417df2f55cd544c28dd7b74bff1ebf920a15e

Maintenance_bot removed a project: Patch-For-Review.May 26 2026, 10:31 PM
Gkm563 added a comment.May 27 2026, 2:10 AM

Thank you for the review and follow-up improvements! I learned a lot from the workflow, CI/CD process, and feedback during this contribution. Glad to contribute.

Gkm563 moved this task from Incoming to Completed on the RoadToWiki board.May 27 2026, 2:10 AM
gerritbot added a comment.Jun 3 2026, 1:59 PM

Change #1297142 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-05-19-223625 to 2026-06-03-020126

https://gerrit.wikimedia.org/r/1297142

gerritbot added a project: Patch-For-Review.Jun 3 2026, 1:59 PM
gerritbot added a comment.Jun 3 2026, 2:19 PM

Change #1297142 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-05-19-223625 to 2026-06-03-020126

https://gerrit.wikimedia.org/r/1297142

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.Jun 3 2026, 2:22 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 3 2026, 2:31 PM
Jdforrester-WMF closed this task as Resolved.Jun 3 2026, 2:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits