Page MenuHomePhabricator
Create Task
Maniphest T426358

Adapt all skins to use modern menu system for footer generation
Open, MediumPublic
Actions

Description

Background

Following T318376: Make universal skin hook able to modify footer menus we'd like to update all skins to use #data-portlets.data-footer-places to render footer rather than #data-footer

Requirements

  • Make sure menu items added to footer via SkinTemplateNavigation::Universal display in all skins regardless of whether they have upgraded.

Phase 1

  • Nostalgia is migrated to use modern menus
  • Modern is migrated to use modern menus
  • CologneBlue is migrated to use modern menus

Phase 2

  • Monobook is migrated to use modern menus
  • Timeless is migrated to use modern menus
  • Vector is migrated to use modern menus

Phase 3

  • Vector 2022 is migrated to use modern menus
  • Minerva is migrated to use modern menus
  • We will update Skin::getTemplateData so data-footer is not output if skin menus option contains one of the footers.

Sign off

  • Create a ticket for the deprecation of SkinAddFooterLink hook in favor of SkinTemplateNavigation::Universal. We'll need to fix all usages first.

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson-WMF created this task.May 14 2026, 10:28 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptMay 14 2026, 10:28 PM
Jdlrobson-WMF renamed this task from Adapt all skins to use modern menu system to Adapt all skins to use modern menu system for footer generation.May 14 2026, 10:28 PM
gerritbot added a comment.May 14 2026, 10:28 PM

Change #1287491 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] POC: Send items from SkinTemplateNavigation::Universal menu to old skins

https://gerrit.wikimedia.org/r/1287491

gerritbot added a project: Patch-For-Review.May 14 2026, 10:29 PM
Jdlrobson-WMF updated the task description. (Show Details)May 14 2026, 10:29 PM
Jdlrobson-WMF mentioned this in T318376: Make universal skin hook able to modify footer menus.May 14 2026, 10:32 PM
alistair3149 subscribed.May 15 2026, 5:45 AM
gerritbot added a comment.May 28 2026, 9:13 PM

Change #1295076 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/core@master] Display Universal hook footer items in all skins

https://gerrit.wikimedia.org/r/1295076

gerritbot added a comment.Jun 2 2026, 3:53 PM

Change #1296622 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/core@master] SkinTemplate: Extract footer vars into private method

https://gerrit.wikimedia.org/r/1296622

gerritbot added a comment.Jun 2 2026, 4:56 PM

Change #1296622 merged by jenkins-bot:

[mediawiki/core@master] SkinTemplate: Extract footer vars into private method

https://gerrit.wikimedia.org/r/1296622

Jdlrobson-WMF triaged this task as Medium priority.Jun 9 2026, 4:01 PM
gerritbot added a comment.Jun 9 2026, 4:08 PM

Change #1295076 merged by jenkins-bot:

[mediawiki/core@master] Display Universal hook footer items in all skins

https://gerrit.wikimedia.org/r/1295076

Jdlrobson-WMF assigned this task to HakanIST.Jun 9 2026, 4:10 PM
Jdlrobson-WMF updated the task description. (Show Details)
Jdlrobson-WMF moved this task from Menu prep work / bug fixes to Migrate the things on the MediaWiki-Core-Skin-Architecture (Menus 2.0) board.Jun 9 2026, 4:38 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.7; 2026-06-16).Jun 9 2026, 5:00 PM
gerritbot added a comment.Jun 10 2026, 5:39 PM

Change #1300218 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/skins/Modern@master] Modern: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1300218

HakanIST added a comment.Jun 10 2026, 5:48 PM

Note: buildContentNavigationUrlsInternal() gives ca- prefix to footer items added via Universal hook without explicit id. Worth a follow-up?

gerritbot added a comment.Jun 10 2026, 7:37 PM

Change #1287491 abandoned by Jdlrobson:

[mediawiki/core@master] POC: Send items from SkinTemplateNavigation::Universal menu to old skins

Reason:

Done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1295076

https://gerrit.wikimedia.org/r/1287491

Jdlrobson-WMF updated the task description. (Show Details)Jun 11 2026, 4:36 PM
gerritbot added a comment.Jun 11 2026, 4:40 PM

Change #1300218 merged by jenkins-bot:

[mediawiki/skins/Modern@master] Modern: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1300218

gerritbot added a comment.Jun 11 2026, 4:42 PM

Change #1300841 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/skins/CologneBlue@master] CologneBlue: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1300841

gerritbot added a comment.Jun 11 2026, 4:56 PM

Change #1300852 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/skins/Vector@master] Vector: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1300852

gerritbot added a comment.Jun 12 2026, 4:57 AM

Change #1300841 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@master] CologneBlue: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1300841

Jdlrobson-WMF updated the task description. (Show Details)Jun 12 2026, 4:07 PM
Jdlrobson-WMF added a parent task: T315015: Create a single truly universal hook to modify all menus provided by core.Jun 12 2026, 4:44 PM
Jdlrobson-WMF mentioned this in T315018: Deprecate SkinAddFooterLinks hook.
gerritbot added a comment.Jun 12 2026, 6:46 PM

Change #1301419 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/skins/MinervaNeue@master] Minerva: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1301419

gerritbot added a comment.Jun 13 2026, 2:11 PM

Change #1301477 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/skins/Timeless@master] Timeless: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1301477

Jdlrobson subscribed.Jun 13 2026, 4:20 PM

@HakanIST I'd suggest that we DO NOT output data-footer for skins who define footer in menu definition in getTemplateData. That would save a lot of processing power. It would also help with us migrating skins away from data-footer usage in templates in future. What do you think?

HakanIST added a comment.Jun 13 2026, 8:33 PM
In T426358#12016059, @Jdlrobson wrote:

@HakanIST I'd suggest that we DO NOT output data-footer for skins who define footer in menu definition in getTemplateData. That would save a lot of processing power. It would also help with us migrating skins away from data-footer usage in templates in future. What do you think?

Makes sense, happy to help with the core patch for that once the skin migrations land.

gerritbot added a comment.Jun 13 2026, 8:37 PM

Change #1301484 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/skins/Nostalgia@master] Nostalgia: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1301484

gerritbot added a comment.Jun 14 2026, 6:59 AM

Change #1301597 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/skins/Vector@master] Vector 2022: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1301597

Jdlrobson-WMF updated the task description. (Show Details)Jun 15 2026, 5:22 PM

Monobook was missing from the requirements so I added it. I suggest we merge phase 2 tomorrow (and wait an additional week for Vector 2022 and Minerva given they are our flagship skins and have the most traffic)

gerritbot added a comment.Jun 15 2026, 7:34 PM

Change #1301484 abandoned by HakanIST:

[mediawiki/skins/Nostalgia@master] Nostalgia: Render footer from portlet menus

Reason:

Nostalgia is frozen and shouldn't gain footer extensibility. Leaving it on the old path per Jon's review.

https://gerrit.wikimedia.org/r/1301484

gerritbot added a comment.Jun 15 2026, 7:46 PM

Change #1302252 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/skins/MonoBook@master] MonoBook: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1302252

gerritbot added a comment.Jun 16 2026, 6:35 PM

Change #1302252 merged by jenkins-bot:

[mediawiki/skins/MonoBook@master] MonoBook: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1302252

gerritbot added a comment.Jun 16 2026, 6:38 PM

Change #1302937 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/skins/Timeless@master] Timeless: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1302937

gerritbot added a comment.Jun 16 2026, 6:45 PM

Change #1301477 abandoned by HakanIST:

[mediawiki/skins/Timeless@master] Timeless: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1301477

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.8; 2026-06-23); removed: MW-1.47-notes (1.47.0-wmf.7; 2026-06-16).Jun 16 2026, 7:00 PM
Jdlrobson-WMF updated the task description. (Show Details)Jun 16 2026, 8:38 PM
Jdlrobson-WMF updated the task description. (Show Details)Jun 17 2026, 8:27 PM
Jdlrobson-WMF added a comment.Jun 17 2026, 9:01 PM

@HakanIST I'll review Minerva and Vector 2022 after the next branch cut to minimize risk of this change. We will have more confidence in those if the roll outs to Monobook/Timeless/Vector do not present any footer issues. Thanks again for pushing this forward!

gerritbot added a comment.Jun 17 2026, 9:13 PM

Change #1302937 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Timeless: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1302937

gerritbot added a comment.Jun 17 2026, 9:30 PM

Change #1300852 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Vector legacy: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1300852

gerritbot added a comment.Mon, Jun 29, 10:18 PM

Change #1301597 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Vector 2022: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1301597

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.9; 2026-06-30); removed: MW-1.47-notes (1.47.0-wmf.8; 2026-06-23).Mon, Jun 29, 11:00 PM
Jdlrobson-WMF updated the task description. (Show Details)Tue, Jun 30, 1:54 AM
gerritbot added a comment.Tue, Jun 30, 3:19 PM

Change #1301419 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Minerva: Render footer from portlet menus

https://gerrit.wikimedia.org/r/1301419

Jdlrobson-WMF updated the task description. (Show Details)Tue, Jun 30, 3:20 PM
Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 30, 3:31 PM
ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.10; 2026-07-07); removed: MW-1.47-notes (1.47.0-wmf.9; 2026-06-30).Tue, Jun 30, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits