Page MenuHomePhabricator
Create Task
Maniphest T426360

Share Highlight: hide the share button in Minerva's toolbelt for unsupported browsers
Closed, InvalidPublic1 Estimated Story PointsBUG REPORT
Actions

Description

Followup to T424873: [Share Highlights] Unsupported CSS "has" feature

Steps to replicate the issue (include links if applicable):

  • On an older iOS/iPadOS device, enable the share highlight experiment using URL param mpo=share-highlight:treatment
  • Observe the buttons in Minerva's toolbelt

What happens?:

The share button is visible and non-functional because the share highlight experiment does not initialize in browsers that don't support CSS :has.

What should have happened instead?:

The share button should not be visible for unsupported browsers of CSS :has.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Bug was found during testing on iPad mini, software version 12, Safari browser

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Share Highlight: hide the article level share buttonLWatsonmediawiki/extensions/ReaderExperimentsmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

lwatson created this task.May 14 2026, 11:06 PM
lwatson mentioned this in T424873: [Share Highlights] Unsupported CSS "has" feature.
lwatson updated the task description. (Show Details)May 14 2026, 11:09 PM
lwatson changed the task status from Open to In Progress.May 15 2026, 12:27 AM
lwatson claimed this task.
gerritbot added a comment.May 15 2026, 12:30 AM

Change #1287504 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/extensions/ReaderExperiments@master] Share Highlight: hide the article level share button

https://gerrit.wikimedia.org/r/1287504

gerritbot added a project: Patch-For-Review.May 15 2026, 12:30 AM
lwatson moved this task from Committed to Code Review on the Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26) board.May 15 2026, 12:31 AM
lwatson updated the task description. (Show Details)May 15 2026, 12:48 AM
matthiasmullie moved this task from Code Review to QA on the Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26) board.May 15 2026, 12:29 PM
gerritbot added a comment.May 15 2026, 12:38 PM

Change #1287504 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Share Highlight: hide the article level share button

https://gerrit.wikimedia.org/r/1287504

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).May 15 2026, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 15 2026, 1:30 PM
SherryYang-WMF triaged this task as Medium priority.May 15 2026, 10:28 PM
Etonkovidova subscribed.May 18 2026, 3:28 PM

Based on https://caniuse.com/css-has unsupported browsers of CSS :has (), the testing was done in Browserstack emulation (see the table below):

  • Chrome/Edge: Any version prior to 105 (released August 2022).
  • Safari: Any version prior to 15.4 (released March 2022)
  • Firefox: Any version prior to 121 (released December 2023)

@lwatson Below are the results of testing. In short, - the Share button is visible in all browsers/OS and when the Share button is clicked in un-supported browsers, the following error is displayed in the Console:

TypeError: getShareHighlightInstrument is not a function. (In 'getShareHighlightInstrument()', 'getShareHighlightInstrument' is undefined)
components/ShareQuoteDialog.vue
OSBrowsersthe Share button is present?Test results
iOS 13Safari 13yesnot working
iOS 12Safari 12yesnot working
MacOS - Big SurSafari 14.1yesthe Console error: TypeError: getShareHighlightInstrument is not a function. (In 'getShareHighlightInstrument()', 'getShareHighlightInstrument' is undefined) components/ShareQuoteDialog.vue
MacOS-Catalina Safari 13.1yes the same error as above
MacOS - MontereySafari 15.6yeswork as expected
MacOS - CatalinaChrome 105yesworks as expected
MacOS - SequoiaChrome 104yesthe same Console error as above
lwatson set the point value for this task to 1.May 18 2026, 5:06 PM
lwatson added a comment.May 18 2026, 7:53 PM

Thanks @Etonkovidova! I checked beta on my older device and the share button with a pulsing blue dot is still present. Sharing to confirm with your BrowserStack findings.

The ticket is not resolved and is non-blocking for the experiment launch.

Etonkovidova added a comment.May 18 2026, 7:54 PM
In T426360#11933317, @lwatson wrote:

Thanks @Etonkovidova! I checked beta on my older device and the share button with a pulsing blue dot is still present. Sharing to confirm with your BrowserStack findings.

The ticket is not resolved and is non-blocking for the experiment launch.

Thank you, @lwatson for confirming! Agree - it's not blocking.

lwatson closed this task as Invalid.May 19 2026, 4:25 PM
lwatson mentioned this in T426774: Share Highlight: hide the article-level share button for unsupported browsers.

Filed follow-up ticket for post-experiment T426774

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits