Page MenuHomePhabricator

FE - Add Gerrit Code Review workflow for Front-end repository
Open, Needs TriagePublic

Description

  • When a patch is submitted, checks have to run before a reviewer can even come to review the code.
  • When the code is submitted for merging, some checks must run pre- and post-merge, as in other MediaWiki projects and extensions.

This is also needed for this project to maintain standards and run linting.

Event Timeline

Collins updated the task description. (Show Details)

Change #1287509 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[integration/config@master] zuul: add the tool wdaudiolex-fe for ci testing

https://gerrit.wikimedia.org/r/1287509

Change #1287509 merged by jenkins-bot:

[integration/config@master] Zuul: [labs/tools/wdaudiolex-fe] Add Node 24 generic job

https://gerrit.wikimedia.org/r/1287509

Mentioned in SAL (#wikimedia-releng) [2026-05-21T16:33:14Z] <hashar> Reloaded Zuul to enable Node24 CI job for labs/tools/wdaudiolex-fe # T426366

Change #1290831 had a related patch set uploaded (by Hashar; author: Hashar):

[labs/tools/wdaudiolex-fe@main] Use `npm run test` as a CI entrypoint

https://gerrit.wikimedia.org/r/1290831

I have deployed the CI configuration that would enable a job based on Node 24 which runs npm ci && npm run test.

With https://gerrit.wikimedia.org/r/c/labs/tools/wdaudiolex-fe/+/1290831 , I am:

  • deleting the tox.ini file (which is for Python projects).
  • moving jest to npm run jest
  • changing npm run test to invoke npm run lint && npm run build, which would run ESLint and vite build.

Our CI refuses to handle the change because it does not support @ in branch names.

The branch @feat/pagination must thus be renamed via https://gerrit.wikimedia.org/r/admin/repos/labs/tools/wdaudiolex-fe,branches .

Once renamed, you can comment recheck on https://gerrit.wikimedia.org/r/c/labs/tools/wdaudiolex-fe/+/1290831 . That would trigger CI. If all goes well you can then vote Code-Review +2 which would trigger CI to have the change merged.

Cleaned up the @ branch per T427099 and I821dcd is green now.

Change #1290831 merged by jenkins-bot:

[labs/tools/wdaudiolex-fe@main] Use `npm run test` as a CI entrypoint

https://gerrit.wikimedia.org/r/1290831