Page MenuHomePhabricator

hCaptcha: Add GlobalBlocking as a dependency for ConfirmEdit CI jobs
Closed, ResolvedPublic0.25 Estimated Story Points

Description

As part of T426059: hCaptcha risk scores: Hook handler for capturing when a block notice is presented in the Desktop editor we are adding checks on the type of blocks that trigger a blocked edit notice.

In order to be able to run the integration tests that verify the behavior of the new code when a GlobalBlock is encountered, we need to include the GlobalBlocking extension as a CI dependency of ConfirmEdit.

Event Timeline

hector.arroyo changed the task status from Open to In Progress.Fri, May 15, 9:31 AM
hector.arroyo set the point value for this task to 0.5.

Change #1287828 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[integration/config@master] Include GlobalBlocking as a dependency for ConfirmEdit

https://gerrit.wikimedia.org/r/1287828

Change #1287828 merged by jenkins-bot:

[integration/config@master] zuul: [mediawiki/extensions/ConfirmEdit] Add GlobalBlocking dependency

https://gerrit.wikimedia.org/r/1287828

It seems the CI config change is not being picked by the job runners in the former patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ConfirmEdit/+/1286851/45, making the tests fail there.

Dreamy_Jazz renamed this task from hCaptcha: Add GlobalBlocking as a dependnecy for ConfirmEdit CI jobs to hCaptcha: Add GlobalBlocking as a dependency for ConfirmEdit CI jobs.Fri, May 15, 12:14 PM
Dreamy_Jazz updated the task description. (Show Details)