Page MenuHomePhabricator

iOS authorization events being sent to `product_metrics_apps_base` are showing NULL values for the `mediawiki.database` AND rename `element_id` for create account
Open, Needs TriagePublic1 Estimated Story PointsBUG REPORT

Description

2 Data Revision Requests:

Engineers - can we check authorization events being sent to product_metrics_apps_base that are showing NULL values for the mediawiki.database column. **Data**

This wasn't stated in the instrumentation docs because it was when I thought this value was tracked automatically - we later found out it needs to be mapped explicitly, so this isn't technically a 'bug' but a 'need to add' . This will be important when we want to monitor Captcha errors by wiki which is coming up next week. We are seeing some events with the value but most without (see data at bottom of ticket).


While we are changing code can we also rename the element_id value to create_account_button instead of submit_button where:
action = click
action_source = create_account_form
funnel_name = create_account
See Instrumentation deck

Mediawiki.database Data:

I did check all actions/mediawiki.database values for all live versions and see we are showing a mediawiki.database for 114 different wikis - so I can't pinpoint it to one missing wiki, that could be happening but the counts being so high indicate this might be a bug that's affecting all actions. I checked both funnel_names create_account and login_account.


Counts below are from funnel_name = create_account App version 6052 only (wanted to make sure this affected the latest version)

actionCount NULL Database events (Fix)Count NOT NULL Database events (Good)
type1367521729
error26832226
click22008221
fancy_captcha_show15630120
impression13750295
fancy_captcha_success68616
success66056
fancy_captcha_error20135
Test Steps

Fixes are in 8.2.0 (6066) and later builds.

Enable dev settings toggle "Send analytics to wmflabs".
Go to https://stream.wikimedia.beta.wmflabs.org/v2/ui/#/
Watch for events with Stream: "product_metrics.app_base", Instrument name: "apps-authentication"

Event Timeline

SNowick_WMF renamed this task from iOS authorization events being sent to `product_metrics_apps_base` are showing NULL values for the `mediawiki.database` to iOS authorization events being sent to `product_metrics_apps_base` are showing NULL values for the `mediawiki.database` AND rename `element_id` for create account.Mon, May 18, 5:49 PM
SNowick_WMF updated the task description. (Show Details)
SNowick_WMF updated the task description. (Show Details)
SNowick_WMF updated the task description. (Show Details)

Hi @Dbrant! Wondering if Android's mediawiki.database value is always the primary app language for app_base calls? That jumped out to me as possibly wrong on our side. I think it's fine for the instrumentation we have so far (authentication and reading challenge), but I think in the future we'll need to be able to send in different mediawiki.database values than just the primary app language. Let me know what you think.

Wondering if Android's mediawiki.database value is always the primary app language for app_base calls? That jumped out to me as possibly wrong on our side. I think it's fine for the instrumentation we have so far (authentication and reading challenge), but I think in the future we'll need to be able to send in different mediawiki.database values than just the primary app language. Let me know what you think.

Ah yes, we are indeed sending the primary app language (technically the dbname enwiki) to that field. I agree that we should probably think about making this field more contextual to the event being sent... Maybe somehow correlate it with the PageData, if that's also part of the event, i.e. make it be the dbname of the language of the PageData?

Tsevener set the point value for this task to 1.Wed, May 20, 4:24 PM

Verified the mediawiki.database issue looks resolved for app version WikipediaApp/8.2.0.6080, will re-verify when release is out to full user base.

Not seeing re-named element_id but that fix was lower priority.