Page MenuHomePhabricator
Create Task
Maniphest T426489

Replace withConsecutive() in PHPUnit tests to support PHPUnit 10
Open, Needs TriagePublic
Actions

Description

PHPUnit 10 removes the function withConsecutive() which is used when building mock objects
It is deprecated since PHPUnit 9.6 but without warning.

This needs replacement in extensions
There are replacements done via T342110: Upgrade to PHPUnit 9.6, but there are still or new usages.

Do not use a replacement with getInvocationCount() (T426504)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
tests: Replace use of withConsecutive() for PHPUnit 10 compatibilityUmherirrendermediawiki/coremaster+16 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.May 16 2026, 8:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2026, 8:33 AM
Umherirrender added a parent task: T328919: Upgrade PHPUnit in MediaWiki code to PHPUnit 10.May 16 2026, 8:34 AM
Umherirrender added a subtask: T426490: Replace withConsecutive() in Echo tests to support PHPUnit 10.
Umherirrender added a subtask: T426491: Replace withConsecutive() in TimedMediaHandler tests to support PHPUnit 10.
Umherirrender added a subtask: T426492: Replace withConsecutive() in Translate tests to support PHPUnit 10.May 16 2026, 8:36 AM
Umherirrender added a subtask: T426493: Replace withConsecutive() in Wikibase tests to support PHPUnit 10.
Umherirrender mentioned this in T426504: Replace getInvocationCount() in PHPUnit tests to support PHPUnit 10.May 16 2026, 10:34 AM
Umherirrender updated the task description. (Show Details)
Umherirrender mentioned this in T426506: Replace getInvocationCount() in GrowthExperiments tests to support PHPUnit 10.May 16 2026, 10:41 AM
Umherirrender mentioned this in T426507: Replace getInvocationCount() in TestKitchen tests to support PHPUnit 10.
siebrand closed subtask T426492: Replace withConsecutive() in Translate tests to support PHPUnit 10 as Resolved.May 22 2026, 4:00 PM
Umherirrender added a comment.Jun 2 2026, 8:25 PM

It seems a upstream replacement for some situation is in PHPUnit 13: https://phpunit.expert/articles/better-than-withconsecutive.html

gerritbot added a comment.Jun 3 2026, 5:22 PM

Change #1297202 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Replace use of withConsecutive() for PHPUnit 10 compatibility

https://gerrit.wikimedia.org/r/1297202

gerritbot added a project: Patch-For-Review.Jun 3 2026, 5:22 PM
Umherirrender closed subtask T426493: Replace withConsecutive() in Wikibase tests to support PHPUnit 10 as Resolved.Jun 5 2026, 7:31 AM
TheDJ closed subtask T426491: Replace withConsecutive() in TimedMediaHandler tests to support PHPUnit 10 as Resolved.Jun 6 2026, 12:47 PM
gerritbot added a comment.Jun 7 2026, 9:17 PM

Change #1297202 merged by jenkins-bot:

[mediawiki/core@master] tests: Replace use of withConsecutive() for PHPUnit 10 compatibility

https://gerrit.wikimedia.org/r/1297202

Umherirrender removed a project: Patch-For-Review.Jun 7 2026, 9:19 PM
Umherirrender closed subtask T426490: Replace withConsecutive() in Echo tests to support PHPUnit 10 as Resolved.
Umherirrender unsubscribed.
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.6; 2026-06-09).Jun 7 2026, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits