Page MenuHomePhabricator

GlobalPreferencesHandlerTest in IPInfo causes "Empty data set provided by data provider" failures under PHPUnit 10
Closed, ResolvedPublic

Description

PHPUnit 10 marks empty data provider as invalid with the text "Empty data set provided by data provider" and count this as errors.

IPInfo has one test with an empty data provider when the optional dependency GlobalPreferences is not loaded.
The data provider is running before tests are started, also before setUp() which skips the test cases, but cannot skip the provider.

1) MediaWiki\IPInfo\Test\Integration\HookHandler\GlobalPreferencesHandlerTest::testOnGlobalPreferencesSetGlobalPreferences
The data provider specified for MediaWiki\IPInfo\Test\Integration\HookHandler\GlobalPreferencesHandlerTest::testOnGlobalPreferencesSetGlobalPreferences is invalid
Empty data set provided by data provider

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1305469 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/IPInfo@master] GlobalPreferencesHandlerTest: Always return one item from provider

https://gerrit.wikimedia.org/r/1305469

Change #1305469 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] GlobalPreferencesHandlerTest: Always return one item from provider

https://gerrit.wikimedia.org/r/1305469