Page MenuHomePhabricator

Replace getInvocationCount() in GrowthExperiments tests to support PHPUnit 10
Closed, ResolvedPublic

Description

PHPUnit 10 removes the function getInvocationCount() which is used when building mock objects

This requires to remove GrowthExperiments\Tests\InvokedBetween, it extends the PHPUnit internal class PHPUnit\Framework\MockObject\Rule\InvocationOrder
Do not replace with withConsecutive() (T426489)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Moving this was accidental.

Change #1296668 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] tests: Replace use of getInvocationCount() for PHPUnit 10 compatibility

https://gerrit.wikimedia.org/r/1296668

Change #1296671 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] tests: Remove InvokedBetween for PHPUnit 10 compatibility

https://gerrit.wikimedia.org/r/1296671

Change #1296671 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: Remove InvokedBetween for PHPUnit 10 compatibility

https://gerrit.wikimedia.org/r/1296671

Change #1296668 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: Replace use of getInvocationCount() for PHPUnit 10 compatibility

https://gerrit.wikimedia.org/r/1296668