Page MenuHomePhabricator
Create Task
Maniphest T426517

Update giorgiosironi/eris in mediawiki/core for php8.4 support / PHPUnit 10 support
Open, Needs TriagePublic
Actions

Description

mediawiki/core require-dev giorgiosironi/eris (maybe not using it), this is also require-dev by WikibaseLexeme.

V0.14 declares Compatibility

  • PHP 7.4, 8.0, 8.1, 8.2
  • PHPUnit 8.x, 9.x

V1.1 declares Compatibility

  • PHP 8.1, 8.2, 8.3, 8.4
  • PHPUnit 10.x, 11.x, 12.x, 13.x

Update is required to support PHP 8.4 support ("Implicitly marking parameter $exception as nullable is deprecated, the explicit nullable type must be used instead"), it seems php8.5 is not supported yet

But it must be updated together with PHPUnit 10 (T328919: Upgrade PHPUnit in MediaWiki code to PHPUnit 10)
The first update results in a revert (see T406470: Wikibase/WikibaseLexeme CI broken: PHP Fatal error: An alias (traitDumpSeedForReproducing) was defined for method dumpSeedForReproducing(), but this method does not exist), for more information, about broken WikibaseLexeme.

Cannot removed from core due to T220723#11977696

Related Objects
Search...

Event Timeline

Umherirrender created this task.Sat, May 16, 4:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, May 16, 4:05 PM
Umherirrender added a parent task: T328919: Upgrade PHPUnit in MediaWiki code to PHPUnit 10.Sat, May 16, 4:06 PM
Umherirrender updated the task description. (Show Details)Sat, May 16, 4:16 PM
Reedy updated the task description. (Show Details)Sun, May 17, 8:01 PM
Reedy subscribed.Sun, May 17, 8:09 PM

rMW25e6dbdb1a41: Install giorgiosironi/eris as require-dev suggests it was added for WikibaseLexeme specifically, which blames T188354: Remove phpunit/phpunit dependencies from extensions's composer.json.

MathSearch has an apparent useage statement, which is unused (according to PhpStorm).. Otherwise it's all WikibaseLexeme.

There's other entries in core's composer.json that have been added to core because $reasons, such as hamcrest/hamcrest-php.

If we can work out a way to remove these from core, and back to the repos they're used in... And not break their tests, we really should get this done!

Jdforrester-WMF added a project: Wikidata Lexicographical data.Mon, May 18, 2:32 PM
Maintenance_bot added a project: Wikidata.Mon, May 18, 3:29 PM
Umherirrender added a comment.Mon, May 18, 7:02 PM

The HamcrestPHPUnitIntegration trait is used by more extensions:
https://codesearch.wmcloud.org/search/?q=HamcrestPHPUnitIntegration

Umherirrender updated the task description. (Show Details)Tue, Jun 2, 7:40 PM
Umherirrender unsubscribed.Sun, Jun 7, 9:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits