Page MenuHomePhabricator

Include "Mobile Apps" in "MediaWiki & services at WMF" preset for Codesearch
Open, Needs TriagePublic

Description

Its only three repos:

While these are technically not deployed server-side as part of the MediaWiki stack at WMF, they are as much as a first-party WMF consumer of MediaWiki code, as services like PCS (mediawiki/services/mobileapps) and Wikifeeds which are standalone codebases that make API calls to MediaWiki.

The benefit of including it, and thus making sure code patterns that require migration of sorts are found, I think outweights the potential downside of a false positive.

We already need to use file filters like php to limit results to server-side PHP code, because there is client-side JavaScript code that consumes (instead of defines) the MediaWiki API in MediaWiki core itself, in MediaWiki extensions, and in the various microservices.

See also:

Event Timeline

The Commons app isn't really "at WMF", it's a third-party app (although a very prominent one).

Change #1289462 had a related patch set uploaded (by ArielGlenn; author: ArielGlenn):

[labs/codesearch@master] Include the mobile app repos by default when MW and services is searched

https://gerrit.wikimedia.org/r/1289462

Change #1289462 merged by jenkins-bot:

[labs/codesearch@master] write_config: Include mobile apps in preset for MediaWiki & services

https://gerrit.wikimedia.org/r/1289462