Page MenuHomePhabricator
Create Task
Maniphest T426877

Settings / Quick action button overlaps language name
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The language selector opens with the settings / quick actions icon overlapping the language list.

See

image.png (870×589 px, 136 KB)

What should have happened instead?:
The quick actions / settings icon should not overlap the language list.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ULS rewrite: Fix quick actions trigger overlap and highlight behaviormediawiki/extensions/UniversalLanguageSelectormaster+32 -22
Customize query in gerrit

Event Timeline

abi_ created this task.Wed, May 20, 4:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, May 20, 4:29 PM
abi_ claimed this task.Wed, May 20, 4:29 PM
abi_ triaged this task as High priority.
abi_ moved this task from Backlog to In progress on the LPL Projects (ULS rewrite) board.
abi_ set the point value for this task to 2.
abi_ added a project: LPL Essential (FY2025-26 Q3&4).
abi_ moved this task from Backlog to In Progress on the LPL Essential (FY2025-26 Q3&4) board.
gerritbot added a comment.Wed, May 20, 4:30 PM

Change #1290023 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS Rewrite: Fix quick actions trigger overlap and highlight behavior

https://gerrit.wikimedia.org/r/1290023

gerritbot added a project: Patch-For-Review.Wed, May 20, 4:30 PM
abi_ added a comment.Thu, May 21, 8:06 AM

I've added some padding to the last column of the language selector to make space for the quick actions trigger.

image.png (850×598 px, 56 KB)

image.png (820×530 px, 58 KB)

Nikerabbit added a project: Design.Thu, May 21, 8:30 AM
gerritbot added a comment.Sun, May 24, 10:26 AM

Change #1290023 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Fix quick actions trigger overlap and highlight behavior

https://gerrit.wikimedia.org/r/1290023

Maintenance_bot removed a project: Patch-For-Review.Sun, May 24, 10:30 AM
abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (FY2025-26 Q3&4) board.Mon, May 25, 1:45 PM
Nikerabbit added a project: MW-1.47-notes (1.47.0-wmf.4; 2026-05-26).Thu, May 28, 8:21 AM
Nikerabbit moved this task from Pending Deployment to Need QA on the LPL Essential (FY2025-26 Q3&4) board.
Nikerabbit added subscribers: SGautam_WMF, Nikerabbit.Mon, Jun 1, 7:19 AM

@SGautam_WMF Please review when you have time to decide if this is good enough for now or whether we explore a better solution.

SGautam_WMF added a comment.Tue, Jun 2, 10:49 AM

the proposed fix seems fine to me

Nikerabbit closed this task as Resolved.Tue, Jun 2, 11:24 AM
Nikerabbit moved this task from Need QA to Done on the LPL Essential (FY2025-26 Q3&4) board.
Nikerabbit added a comment.Wed, Jun 3, 6:12 PM

Just noting that it still overlaps the scrollbar, definitely for me because I am using a style with bigger scrollbars.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits