Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

While investigating this task, I noticed that exposure_version is currently computed in ResourceLoader\Hooks::getExposureVersion().

For the fallback case ("calculate the version internally"), should experiment.version reuse this existing calculation, or is a different versioning strategy intended?

In T427090#11975741, @Vanshika wrote:

For the fallback case ("calculate the version internally"), should experiment.version reuse this existing calculation, or is a different versioning strategy intended?

Good spot. Yes. exposure_version can be used as the fallback value.

Change #1298112 had a related patch set uploaded (by Vanshika11; author: Vanshika11):

[mediawiki/extensions/TestKitchen@master] TestKitchen: Capture experiment version in analytics events

https://gerrit.wikimedia.org/r/1298112

@Vanshika: Would you like to have a go at updating the product_metrics/experiment schema fragment?

@phuedx Yes, I'd be happy to take a look at updating the product_metrics/experiment schema fragment.

@Vanshika: Have you had a chance to take a look at updating the schema fragment?

@phuedx Yes, I have. I took some time to explore the schemas-event-secondary repository and identified the product_metrics/experiment schema fragment. I'm working on updating it to include experiment.version and will prepare a patch.

I've updated the product_metrics/experiment schema fragment by adding experiment.version and bumping the fragment version to 2.1.0. Before I open the MR, should I keep the change limited to the fragment, or would you also like me to update the base schemas (web/base, app/base, and base_with_ip) to reference the new fragment version?

In T427090#12057591, @Vanshika wrote:

I've updated the product_metrics/experiment schema fragment by adding experiment.version and bumping the fragment version to 2.1.0. Before I open the MR, should I keep the change limited to the fragment, or would you also like me to update the base schemas (web/base, app/base, and base_with_ip) to reference the new fragment version?

Yes please!

vanshi11 opened https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/128

Add experiment.version to product_metrics schema

@Vanshika I'm precisely working on adding another new field to the base schemas (phase_index) via https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/127 and I have seen you are working on adding version to the same ones. Would you want to unify efforts and add also phase_index as a new field to your MR? Then, happy to close mine and keep only yours to add both new fields

Thanks! @Sfaci Sure, I'm happy to combine both changes into this MR. I'll add phase_index as well and update the MR accordingly.

sfaci merged https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/128

Add experiment.version and phase_index to product_metrics schema

hi @phuedx, The schema changes have now been merged:
https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/128

The corresponding TestKitchen Gerrit change is ready for review:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TestKitchen/+/1298112

In T427090#12099031, @Vanshika wrote:

hi @phuedx, The schema changes have now been merged:
https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/128

The corresponding TestKitchen Gerrit change is ready for review:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TestKitchen/+/1298112

Now that we have a new version of the web/base schema, 2.1.0, the corresponding TestKitchen MR should be updated accordingly. The 2.0.0 version will be still there, and we should use now 2.1.0 where version has been included. Also keep in mind that https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TestKitchen/+/1302171 (where phasex_index is being added also as a new field) will be doing the same

I've updated the corresponding TestKitchen Gerrit change to use schema version 2.1.0. I've rebased it on the latest master and uploaded a new patchset. It's ready for review.

Change #1298112 merged by jenkins-bot:

[mediawiki/extensions/TestKitchen@master] TestKitchen: Capture experiment version in analytics events

https://gerrit.wikimedia.org/r/1298112