Some things we need to fix:

1. In both versions, hovering on the badge removes the border. The white border should not disappear instead there was this on tap style explored by @Volker_E that would be nice to have.
2. For delight version - the first time pop up pointing to badge is not appearing.
3. On confirmation dialog the white badge border is not there. It should look the same as the badge on the header with a shadow outline so that the white border becomes visible.
4. "Hide badge" button right now is using a style that blends with the article page and makes the button less visible. Could we use progressive normal style or is there a different style we use for floating buttons?

@Sneha I'd also ask once more about the "Yes, hide the badge" label. It might

1. lead to translation overflow in one of our audience wikis (German: "Ja, verstecke den Badge")
2. We should unify on "remove badge" in both treatments – B already uses remove.
3. We don't use full sentences in our labels, it should be active first person: "Remove badge". The importance is delivered with destructive treatment, not via "Yes" in the label.

Agree?

Change #1300171 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikimediaCustomizations@master] Donor Delight Badge, styles: Amending to final design review feedback

https://gerrit.wikimedia.org/r/1300171

@Volker_E sounds good. I am attaching a mock for alignment.

@Volker_E and I had a quick async discussion and we have decided to replace "hide" to "remove" based on Volker's suggestion. Adding here for documentating decisions.

Change #1300186 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikimediaCustomizations@master] Donor Delight Badge: Unify on "Remove badge" language across treatments

https://gerrit.wikimedia.org/r/1300186

In T427313#12005179, @Sneha wrote:

@Volker_E sounds good. I am attaching a mock for alignment.

@Sneha @Volker_E What should the body text be? this is whats in the patch now but it read a bit funny to me https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaCustomizations/+/1300186

"This heart is a thank you badge for your donation. Removing it from your view won't let you restore it."

In T427313#12002653, @Sneha wrote:

Some things we need to fix:

1. In both versions, hovering on the badge removes the border. The white border should not disappear instead there was this on tap style explored by @Volker_E that would be nice to have.
2. For delight version - the first time pop up pointing to badge is not appearing.
3. On confirmation dialog the white badge border is not there. It should look the same as the badge on the header with a shadow outline so that the white border becomes visible.
4. "Hide badge" button right now is using a style that blends with the article page and makes the button less visible. Could we use progressive normal style or is there a different style we use for floating buttons?

@Sneha

2. its working for me, perhaps its not appearing cuz you already saw the popup when you were testing treatment b. paste this into the console to reset the experience to the first time: mw.user.clientPrefs.set( 'minerva-badge', '0' );
3. this is what im seeing for treatment C. isnt this the progressive normal style already?
   

In T427313#12005954, @bwang wrote:

In T427313#12005179, @Sneha wrote:

@Volker_E sounds good. I am attaching a mock for alignment.

@Sneha @Volker_E What should the body text be? this is whats in the patch now but it read a bit funny to me https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaCustomizations/+/1300186

"This heart is a thank you badge for your donation. Removing it from your view won't let you restore it."

Your copy proposal @bwang made more sense than the former: "This heart is a thank you badge for your donation. The badge cannot be restored after it is removed." I'd suggest we go with that.

@bwang @Volker_E the new copy sounds good to me.

@bwang looks like were looking at different builds. Based on your screenshot for the floating button it looks good.

Change #1300842 had a related patch set uploaded (by Anne Tomasevich; author: VolkerE):

[mediawiki/extensions/WikimediaCustomizations@wmf/1.47.0-wmf.6] Donor Delight Badge: Unify on "Remove badge" language across treatments

https://gerrit.wikimedia.org/r/1300842

Change #1300186 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@master] Donor Delight Badge: Unify on "Remove badge" language across treatments

https://gerrit.wikimedia.org/r/1300186

Change #1300171 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@master] Donor Delight Badge, styles: Amending to final design review feedback

https://gerrit.wikimedia.org/r/1300171

Change #1300896 had a related patch set uploaded (by Anne Tomasevich; author: VolkerE):

[mediawiki/extensions/WikimediaCustomizations@wmf/1.47.0-wmf.6] Donor Delight Badge, styles: Amending to final design review feedback

https://gerrit.wikimedia.org/r/1300896

Change #1300842 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@wmf/1.47.0-wmf.6] Donor Delight Badge: Unify on "Remove badge" language across treatments

https://gerrit.wikimedia.org/r/1300842

Change #1300896 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@wmf/1.47.0-wmf.6] Donor Delight Badge, styles: Amending to final design review feedback

https://gerrit.wikimedia.org/r/1300896

Mentioned in SAL (#wikimedia-operations) [2026-06-11T20:17:31Z] <jdrewniak@deploy1003> Started scap sync-world: Backport for [[gerrit:1300842|Donor Delight Badge: Unify on "Remove badge" language across treatments (T427313)]], [[gerrit:1300843|[A11y] Donor Badge: Remove Badge button disappears too quickly (T428646)]], [[gerrit:1300896|Donor Delight Badge, styles: Amending to final design review feedback (T427313)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-11T20:34:51Z] <jdrewniak@deploy1003> annet, jdrewniak: Backport for [[gerrit:1300842|Donor Delight Badge: Unify on "Remove badge" language across treatments (T427313)]], [[gerrit:1300843|[A11y] Donor Badge: Remove Badge button disappears too quickly (T428646)]], [[gerrit:1300896|Donor Delight Badge, styles: Amending to final design review feedback (T427313)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug

Mentioned in SAL (#wikimedia-operations) [2026-06-11T20:51:42Z] <jdrewniak@deploy1003> Finished scap sync-world: Backport for [[gerrit:1300842|Donor Delight Badge: Unify on "Remove badge" language across treatments (T427313)]], [[gerrit:1300843|[A11y] Donor Badge: Remove Badge button disappears too quickly (T428646)]], [[gerrit:1300896|Donor Delight Badge, styles: Amending to final design review feedback (T427313)]] (duration: 34m 10s)

After reviewing T425459: Donor badge experiment: Setup donor badge, I decided to add my notes here to keep UI issues in one place.

Checked in enwiki beta

Issues:
(1) there is typography mismatch between Figma and codex (a known issue; see also https://phabricator.wikimedia.org/T419395#12003722)
The popover displays small font vs medium font specified in Figma:

enwiki beta	Figma
#minerva-badge-popover h3 {font-size: var(--font-size-x-small,0.75rem)

(2) Accessibility check identifies some issue with the element:

(3) I did not see the popover for 'donor-delight-badge' group - when the heart icon clicked, the animation starts immediately. I tested it on enwiki beta and on https://test.wikipedia.org/w/index.php?title=Main_Page&mpo=donor-delight-badge%3Atreatment-c-delightful (click on the gif below)

Thanks @Etonkovidova.
(1) and (2) are easily fixable. I have actually wondering about the same thing on too small font-size, but when looking up Figma, it seemed the right tokens. Pls just shortly verify @Sneha.
With (3) I'm a bit confused, as this has been behaving differently before. I'd also appreciate @bwang eyes on it.

In T427313#12013974, @Volker_E wrote:

Thanks @Etonkovidova.
(1) and (2) are easily fixable. I have actually wondering about the same thing on too small font-size, but when looking up Figma, it seemed the right tokens. Pls just shortly verify @Sneha.

Thanks, @Volker_E!

Just to clarify
Regarding (1) issue - the comment I mentioned (https://phabricator.wikimedia.org/T419395#12003722) refers to a similar problem that Growth team had. There is a follow-up comment from @DTorsani-WMF (https://phabricator.wikimedia.org/T419395#12004453) - not quite sure if it fixes the tokens mismatch and some additional patch(es) are needed.

Regarding (2) - as I mentioned it's an old accessibility issue, not introduced by any recent changes. I just thought since we are working on Watch label, probably it'd be good to fix it as well.

With (3) I'm a bit confused, as this has been behaving differently before. I'd also appreciate @bwang eyes on it.

@bwang
Re-checked - turned out the behavior is trickier than I expected. I guess it's by design?

• First time on a page (beta or testwiki)I use mw.user.clientPrefs.set( 'minerva-badge', '1' );

• then, I use

mw.testKitchen.overrideExperimentGroup('donor-delight-badge', 'treatment-c-delightful');

The badge appears and the popover appears:

Then, after tapping - the animation starts and "Remove badge" floating button appears at the button:

After that, I don't see the the popover anymore.

Change #1301392 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikimediaCustomizations@master] Donor Delight Badge: Add accessible label and hide popover from AT

https://gerrit.wikimedia.org/r/1301392

Change #1301392 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@master] Donor Delight Badge: Add accessible label and hide popover from AT

https://gerrit.wikimedia.org/r/1301392

Change #1303517 had a related patch set uploaded (by Jdlrobson; author: VolkerE):

[mediawiki/extensions/WikimediaCustomizations@wmf/1.47.0-wmf.6] Donor Delight Badge: Add accessible label and hide popover from AT

https://gerrit.wikimedia.org/r/1303517

Change #1303517 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@wmf/1.47.0-wmf.6] Donor Delight Badge: Add accessible label and hide popover from AT

https://gerrit.wikimedia.org/r/1303517

Mentioned in SAL (#wikimedia-operations) [2026-06-17T22:14:08Z] <jdlrobson@deploy1003> Started scap sync-world: Backport for [[gerrit:1303517|Donor Delight Badge: Add accessible label and hide popover from AT (T427313)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-17T22:31:50Z] <jdlrobson@deploy1003> jdlrobson: Backport for [[gerrit:1303517|Donor Delight Badge: Add accessible label and hide popover from AT (T427313)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-06-17T22:45:09Z] <jdlrobson@deploy1003> Finished scap sync-world: Backport for [[gerrit:1303517|Donor Delight Badge: Add accessible label and hide popover from AT (T427313)]] (duration: 31m 01s)

The last AC is done (checked on `testwiki wmf.8):

Simple (B) & Delightful (C): On confirmation dialog the white badge border is not there. It should look the same as the badge on the header with a shadow outline so that the white border becomes visible.