WikimediaEvents depends on TestKitchen as of T419679: Make WikimediaEvents depend on TestKitchen. Previously, developers would have to use the optional services dependency injection feature (PHP) and/or the mw.loader.using feature (JS) to manage a soft dependency on TestKitchen. All of that management code can now be removed.
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| ext.wikimediaEvents: Completely remove loading of ext.testKitchen RL module | Phuedx | mediawiki/extensions/WikimediaEvents | master | +2 -4 |
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3
Change #1296506 had a related patch set uploaded (by Vanshika11; author: Vanshika11):
[mediawiki/extensions/WikimediaEvents@master] T427382: Remove redundant ext.testKitchen loading
Change #1296506 had a related patch set uploaded (by Vanshika11; author: Vanshika11):
[mediawiki/extensions/WikimediaEvents@master] T427382: Remove redundant ext.testKitchen loading
Change #1296506 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] T427382: Remove redundant ext.testKitchen loading
There are 3 instances of the ext.testKitchen module being loaded still – https://codesearch.wmcloud.org/search/?q=%27ext.testKitchen%27&files=&excludeFiles=&repos=Extension%3AWikimediaEvents. Let's get them tidied up as well!
Change #1305640 had a related patch set uploaded (by Phuedx; author: Phuedx):
[mediawiki/extensions/WikimediaEvents@master] ext.wikimediaEvents: Completely remove loading of ext.testKitchen RL module
Change #1305640 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] ext.wikimediaEvents: Completely remove loading of ext.testKitchen RL module