Page MenuHomePhabricator
Create Task
Maniphest T427679

[Image Browsing] Carousel: Users should not see desktop MMV experience when clicking an image
Open, HighPublic1 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Desktop MMV lightbox loads (which is not optimized for mobile)

What should have happened instead?:
We should continue to show the existing (and much more minimal) MobileFrontend "carousel" (no relation) when users click an image on the page.
In the near future we will give users a new mobile MMV lightbox experience, but for now we should prefer the current mobile UX to the legacy desktop UX.

Other information (browser name/version, screenshots, etc.):
This issue happens under both parsoid and legacy parser.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Carousel: Defer to MobileFrontend lightbox on mobilemediawiki/extensions/MultimediaViewerwmf/1.47.0-wmf.4+99 -23
Carousel: Defer to MobileFrontend lightbox on mobilemediawiki/extensions/MultimediaViewermaster+99 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

egardner created this task.Fri, May 29, 7:51 PM
egardner claimed this task.Fri, May 29, 9:00 PM
egardner triaged this task as High priority.
egardner moved this task from Committed to Doing on the Reader Growth Team (Sprint 5 (May 27 - Jun 9) Q4 25/26) board.
gerritbot added a comment.Fri, May 29, 9:29 PM

Change #1295503 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/extensions/MultimediaViewer@master] Carousel: Defer to MobileFrontend lightbox on mobile

https://gerrit.wikimedia.org/r/1295503

gerritbot added a project: Patch-For-Review.Fri, May 29, 9:29 PM
egardner moved this task from Doing to Code Review on the Reader Growth Team (Sprint 5 (May 27 - Jun 9) Q4 25/26) board.Fri, May 29, 9:30 PM
egardner set the point value for this task to 1.
PatchDemoBot added a comment.Fri, May 29, 9:32 PM

Test wiki created on Patch demo by EGardner (WMF) using patch(es) linked to this task:
https://274be381d4.catalyst.wmcloud.org/w/

egardner added a comment.Fri, May 29, 9:56 PM

You can test this in Patchdemo now:

Go to https://274be381d4.catalyst.wmcloud.org/wiki/International_Space_Station (or any page with images)
Login as Alice / patchdemo1 (this user has the mobile carousel feature enabled already)
Use mobile view to see the article

What should happen

The legacy Mobile Frontend lightbox should display if you click a carousel or body thumbnail

Bonus: the new mobile detail view still works if you add ?mmvBeta=1 to the URL

Aklapper added a project: MediaViewer.Fri, May 29, 11:06 PM
gerritbot added a comment.Mon, Jun 1, 9:56 AM

Change #1295503 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Carousel: Defer to MobileFrontend lightbox on mobile

https://gerrit.wikimedia.org/r/1295503

mfossati moved this task from Code Review to QA on the Reader Growth Team (Sprint 5 (May 27 - Jun 9) Q4 25/26) board.Mon, Jun 1, 10:18 AM
Maintenance_bot removed a project: Patch-For-Review.Mon, Jun 1, 10:31 AM
gerritbot added a comment.Mon, Jun 1, 4:27 PM

Change #1295962 had a related patch set uploaded (by Marco Fossati; author: Eric Gardner):

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.4] Carousel: Defer to MobileFrontend lightbox on mobile

https://gerrit.wikimedia.org/r/1295962

gerritbot added a project: Patch-For-Review.Mon, Jun 1, 4:27 PM
gerritbot added a comment.Mon, Jun 1, 11:20 PM

Change #1295962 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.4] Carousel: Defer to MobileFrontend lightbox on mobile

https://gerrit.wikimedia.org/r/1295962

Stashbot mentioned this in T427542: [Image Browsing] Carousel: MMV fails to load when clicking on carousel items that correspond to lazy image placeholders (legacy parser only).Mon, Jun 1, 11:20 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-01T23:20:20Z] <jdlrobson@deploy1003> Started scap sync-world: Backport for [[gerrit:1295963|Make MultimediaViewer compatible with MobileFrontend legacy parser (T427542)]], [[gerrit:1295962|Carousel: Defer to MobileFrontend lightbox on mobile (T427679)]]

Stashbot added a comment.Mon, Jun 1, 11:22 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-01T23:22:03Z] <jdlrobson@deploy1003> mfossati, jdlrobson: Backport for [[gerrit:1295963|Make MultimediaViewer compatible with MobileFrontend legacy parser (T427542)]], [[gerrit:1295962|Carousel: Defer to MobileFrontend lightbox on mobile (T427679)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Mon, Jun 1, 11:27 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-01T23:27:37Z] <jdlrobson@deploy1003> Finished scap sync-world: Backport for [[gerrit:1295963|Make MultimediaViewer compatible with MobileFrontend legacy parser (T427542)]], [[gerrit:1295962|Carousel: Defer to MobileFrontend lightbox on mobile (T427679)]] (duration: 07m 17s)

Jdlrobson-WMF added subscribers: mfossati, Jdlrobson-WMF.Mon, Jun 1, 11:27 PM

This has now been backported to production. cc @mfossati

Maintenance_bot removed a project: Patch-For-Review.Mon, Jun 1, 11:30 PM
mfossati moved this task from QA to Signoff on the Reader Growth Team (Sprint 5 (May 27 - Jun 9) Q4 25/26) board.Tue, Jun 2, 9:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits