| Niepodkoloryzowany | |
| May 30 2026, 12:41 PM |
| F85430546: image.png | |
| May 30 2026, 12:41 PM |
| F85428974: image.png | |
| May 30 2026, 12:41 PM |
The classes tleft and tright were recently deprecated in T426452: [for action] tleft and tright should be replaced with floatleft and floatright if used.
But align="left" still generates tleft in <mapframe>:
Omitting the align parameter completely outputs tright:
This may lead to layout bugs, so the classes should be updated to floatleft and floatright.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | ABreault-WMF | T318433 Templates (and extensions) that mimic parser media output need migration to new structure | |||
| Open | None | T427709 Replace tright and tleft with floatright and floatleft in <mapframe> |
The output looks like it also didn't get the (Parsoid) figure treatment so it needs correction for that also, and which may be the fundamental issue.
I gave it a try but it's not as easy as it sounds. What Kartographer (intentionally) does is re-creating a piece of HTML that behaves the same as a [[File:…|thumb|left]], for example.
Note there is also a little bit of CSS that (again, intentionally) resets floats inside of Leaflet popups. The file leaflet-overrides.less mentions tleft and tright in one place, along with a few other rules related to thumbnails. I suspect these also need updating to work both the old and the new <figure> syntax.
Change #1297714 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Jgiannelos):
[mediawiki/extensions/Kartographer@master] Replace deprecated tleft and tright classes
Change #1301776 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/Kartographer@master] Thumbnail: Switch to figure layout
Gave a go at switching to <figure>. It's a bit of a job, as due to cached content, we need both the old and the new html to work with the styles for at least a few weeks.
Of note is also https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Kartographer/+/1293140 by @HakanIST which might be a good idea, but which also needs to be backwards compatible with styling, and it's probably better to do both of these things in succession.