Page MenuHomePhabricator

Configure repository review workflow
Closed, ResolvedPublic

Description

Research into this has been done in T427368: Investigate code review in GitLab.

Event Timeline

We should probably set "Squash commits when merging" to "Encourage". Otherwise we'll have to remember checking the box each time there are follow up commits in an MR.

We should set "Target project" to "This project" so we don't accidentally end up doing what I did in T427908.

We should set "Target project" to "This project" so we don't accidentally end up doing what I did in T427908.

Can you explain a bit more, in what stage does one set "This project", and what was it that happened in T427908? I saw something with "opened", "closed" but don't really know why that happened?

I left out some context I realise. That's in the settings for the repo, I think it's under "Merge Requests" or some such. You can set if the default for MR should be to target the main branch of the same project or the upstream project. The latter is part of the reason for the MR that went to upstream in T427908. The other part was me not reading properly when I made the MR 🙈

When the configuration of repository CI is done, I think we should set Merge checks (settings/Merge Request) to Pipelines must succeed:

image.png (1,271×381 px, 73 KB)

Otherwise I think this task is kind of done, since there is nothing more to configure, only things to consider when you make a MR.