Page MenuHomePhabricator
Create Task
Maniphest T42792

jquery.makeCollapsible should avoid page scroll when collapsing elements
Closed, ResolvedPublic
Actions

Description

(In reply to Bug 27488 comment #28)

Following a link to a section in long discussion page:

  • Click the link.
  • Wait for the page to appear (takes a while since the pages are not cached for

users who are logged in)

  • Notice that you have been sent to a different location. No section header

anywhere near.

  • Try to locate the right position anyway.
  • If you can't find it, click the url bar and press Enter. (Maybe the Reload

button also does it in some browsers.)

Maybe the script resources/jquery/jquery.makeCollapsible.js (the function toggleLinkPremade?) could memorize the current scroll position and restore it right after collapsing an element in the page (I think LQT does something like that). This could help if the element is one of those which are above the current section (currently you may end up a few sections below the one you wanted)

Version: unspecified
Severity: normal

Details

Reference
bz40792
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
sortable tables/mw-collapsible no longer causes page jumpmediawiki/coremaster+170 -28
Skins: getDefaultStyles can now define render blocking CSSmediawiki/coremaster+41 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:02 AM
• bzimport added a project: MediaWiki-JavaScript.
• bzimport set Reference to bz40792.
• bzimport added a subscriber: Unknown Object (MLST).
He7d3r created this task.Oct 5 2012, 11:56 AM
Krinkle added a comment.Oct 5 2012, 9:03 PM

That would be one way to work around it pushing down the page, however this will be fixed in the refactor of jquery.makeCollapsible which will do the initial collapse with CSS instead of JavaScript (so by the time the browser even considers jumping to a position, the collapsing has been long taken care of).

This works because CSS applies retroactively and live. So when the html comes into the parser and is rendered by the browser, the state of expansion or collapse is already applied from the start, no transition.

(this does use javascript, but not inside jquery.makeCollapsible, it will use .client-js .mw-collapsed)

He7d3r added a comment.Oct 5 2012, 11:37 PM

I think that CSS solution would not work for the case where someone is adding the class="mw-collapsible mw-collapsed" from a user script and calling
$(...).makeCollapsible()

Krinkle added a comment.Oct 6 2012, 7:25 AM

(In reply to comment #2)

I think that CSS solution would not work for the case where someone is adding
the class="mw-collapsible mw-collapsed" from a user script and calling
$(...).makeCollapsible()

In that case the element would collapse as soon as the class is added. Calling makeCollapsible will then add the relevant event handlers so that the user can change the state.

Note that if javascript is disabled it will always be shown even if CSS hides it with mw-collapsed because the selector would be prefixed with .client-js (which the mw.page module adds to the document).

matmarex edited projects, added MediaWiki-User-Interface, JavaScript; removed MediaWiki-JavaScript.Dec 31 2014, 12:28 AM
Majr merged a task: T110770: Auto-collapsed templates displace anchor tag targets.Nov 2 2015, 8:59 AM
Majr added subscribers: Jdlrobson, Alexiaa, xcombelle and 5 others.
Schnark mentioned this in T125297: Initial jump to fragment in page fails when collapsed element above.Feb 1 2016, 11:00 AM
Schnark merged a task: T125297: Initial jump to fragment in page fails when collapsed element above.
Schnark added subscribers: Schnark, matmarex, StudiesWorld, PerfektesChaos.

T125297 contains some ideas about how to implement a fix.

Samat subscribed.Mar 21 2016, 3:20 PM
He7d3r awarded a token.Jun 25 2016, 5:50 PM
He7d3r unsubscribed.
He7d3r subscribed.
Krinkle reopened subtask T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state) as Open.Jun 14 2017, 9:31 PM
gerritbot subscribed.Apr 4 2018, 11:30 PM

Change 424165 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] mw-collapsible no longer causes page jump

https://gerrit.wikimedia.org/r/424165

gerritbot added a project: Patch-For-Review.Apr 4 2018, 11:30 PM
gerritbot added a comment.Apr 10 2018, 1:23 AM

Change 425211 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Only load mediawiki.jquery.styles if page HTML suggests needed

https://gerrit.wikimedia.org/r/425211

gerritbot added a comment.Apr 23 2018, 9:38 PM

Change 425211 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Skins: getDefaultModules can now define render blocking CSS

https://gerrit.wikimedia.org/r/425211

gerritbot added a comment.Apr 26 2018, 8:18 PM

Change 425211 merged by jenkins-bot:
[mediawiki/core@master] Skins: getDefaultStyles can now define render blocking CSS

https://gerrit.wikimedia.org/r/425211

gerritbot added a comment.May 3 2018, 1:09 AM

Change 424165 merged by jenkins-bot:
[mediawiki/core@master] sortable tables/mw-collapsible no longer causes page jump

https://gerrit.wikimedia.org/r/424165

Jdlrobson added a comment.May 3 2018, 1:26 AM

This should be fixed on the beta cluster now. The change was a tricky one and we have almost a week until next train so if anyone reading can spare some time to test this change out on the beta cluster it would be most appreciated :)

Aklapper mentioned this in T193827: Linking to a specific section in Wikipedia makes the browser jump somewhere else.May 4 2018, 10:11 AM
Jdlrobson mentioned this in T126877: Collapsible table breaks anchor linking.May 4 2018, 3:20 PM
Jdlrobson mentioned this in T67468: Redirects to section are off in Firefox 29.0.1 if there are collapsed elements above the section.
Comfr subscribed.May 4 2018, 7:49 PM
In T42792#4177130, @Jdlrobson wrote:

This should be fixed on the beta cluster now. The change was a tricky one and we have almost a week until next train so if anyone reading can spare some time to test this change out on the beta cluster it would be most appreciated :)

I enabled beta in Wikipedia, which gave me MediaWiki version 1.32.0-wmf.2 (rMWbbd5b517ba9d). The problem still exists. How should I test the fix?

Jdlrobson added a comment.May 4 2018, 8:04 PM

You can test on https://reading-web-staging.wmflabs.org

TheDJ added a parent task: T67468: Redirects to section are off in Firefox 29.0.1 if there are collapsed elements above the section.May 5 2018, 7:55 AM
TheDJ removed a project: Patch-For-Review.
Jdlrobson raised the priority of this task from Low to Medium.May 7 2018, 6:05 PM
Jdlrobson added a project: Web-Team-Backlog-Archived (Tracking).
ovasileva closed subtask T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state) as Resolved.May 8 2018, 10:35 AM
matmarex closed this task as Resolved.May 8 2018, 2:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits