Page MenuHomePhabricator

wbsearchentities rejects limit=max for items and properties
Closed, ResolvedPublic

Description

This is not yet live on wikidata.org for property search, and rolling it out would break adding new statements for structured data on Wikimedia Commons. Item search already responds with Invalid value for parameter "limit". when requesting wbsearchentities with limit=max, but that didn't cause any issues that we know of.

This was caused by the refactoring around T424817. It surfaced through T427695 which shows that the current Wikibase master breaks WikibaseMediaInfo's statement UI.

Event Timeline

Change #1296650 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Search: Disable redundant search limit validation

https://gerrit.wikimedia.org/r/1296650

dancy triaged this task as Unbreak Now! priority.Tue, Jun 2, 6:24 PM
dancy subscribed.

Changing priority to UBN! this since task was added as a train blocker in T423914. I'm currently holding the train.

Given the described scope of the problem (wikidata.org, which is in group1), I will roll the train to group0 now.

Change #1296650 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Search: Disable redundant search limit validation

https://gerrit.wikimedia.org/r/1296650

Change #1297058 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@wmf/1.47.0-wmf.5] Search: Disable redundant search limit validation

https://gerrit.wikimedia.org/r/1297058

Change #1297058 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.47.0-wmf.5] Search: Disable redundant search limit validation

https://gerrit.wikimedia.org/r/1297058