Page MenuHomePhabricator

Donor badge: treatment simple shows pop over on every page view
Open, MediumPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Bucket yourself into the simple treatment when logged out
$.cookie( 'centralnotice_hide_fundraising', '{"v":1,"created":1779379520,"reason":"donate"}', { path: '/' } );
mw.testKitchen.overrideExperimentGroup('donor-delight-badge', 'treatment-b-simple');
  • Refresh the page multiple times

What happens?:
Every time the pop over displays

What should have happened instead?:

The popover should only be displayed to the user once. If the popover is out of the viewable area, ideally this would not count as being seen.

Screenshot 2026-06-02 at 11.00.32 AM.png (442×560 px, 39 KB)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

HFan-WMF triaged this task as High priority.Tue, Jun 2, 6:10 PM

Change #1297225 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/WikimediaCustomizations@master] Ensure donor badge popover is only shown on page load once

https://gerrit.wikimedia.org/r/1297225

Change #1297225 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@master] Ensure donor badge popover is only shown on page load once

https://gerrit.wikimedia.org/r/1297225

The popover is displaying briefly in Chrome due to the animation on it (make sure you have reduce animations enabled). This still needs to be fixed so moving back to Ready.

Change #1298330 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaCustomizations@master] Disable animations if seen, restore on click

https://gerrit.wikimedia.org/r/1298330

Change #1298346 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/WikimediaCustomizations@master] Fix donor badge popup animation flash

https://gerrit.wikimedia.org/r/1298346

bwang removed bwang as the assignee of this task.Fri, Jun 5, 8:04 PM
bwang subscribed.

Change #1298330 abandoned by Jdlrobson:

[mediawiki/extensions/WikimediaCustomizations@master] Disable animations if seen, restore on click

Reason:

The approach in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaCustomizations/+/1298346?usp=search avoids adding to the page. The majority of the patch is refactoring of the JS.

https://gerrit.wikimedia.org/r/1298330

Change #1298346 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@master] Fix donor badge popup animation flash

https://gerrit.wikimedia.org/r/1298346

. If the popover is out of the viewable area, ideally this would not count as being seen.

We should talk about how much of a lift this would be!

Jdlrobson-WMF lowered the priority of this task from High to Medium.Fri, Jun 5, 8:38 PM