Page MenuHomePhabricator

Content collapsed with legacy classes (`collapsible collapsed`) is not visible in VE
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue:

What happens?:

  • Browser scrolls to near the page-top

What should have happened instead?:

  • An external link should've been highlighted.

image.png (599×1 px, 186 KB)

Event Timeline

The errors are from the table in https://ru.wikipedia.org/w/index.php?title=Chevrolet_Tahoe#Продажи section - however the tables are collapsed in VE causing this issue.

The tables appear to be use collapsible and collapsed classes, when they should be using mw-collapsible and mw-collapsed. The latter is supported across MediaWiki, and specifically in VE where the content is always expanded for editing.

Example: https://ru.wikipedia.org/w/index.php?title=%D0%A3%D1%87%D0%B0%D1%81%D1%82%D0%BD%D0%B8%D0%BA:ESanders_(WMF)/sandbox&veaction=edit

It looks like there is a bit of code on many wikis' common.js to convert collapsible to mw-collapsible: makeCollapsibleMwCollapsible. This is regsitered with the wikipage.content hook - however this doesn't fire on VE content.

I think it would be just easier to replace collapsible/collapsed with mw-collapsible/mw-collapsed on these wikis. I will raise this topic on ruwiki village pump.

Also this selector, which has a higher specificity than the one in core, has been pasted around most wikis: https://en.wikipedia.org/w/index.php?title=MediaWiki:Common.css&oldid=1333752946#L-40

Change #1297152 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Collapsed content: Support legacy CSS classes

https://gerrit.wikimedia.org/r/1297152

Esanders renamed this task from Random scroll to top and wrong-Suggestion-type bug(s) to Content collapsed with legacy classes (`collapsible collapsed`) is not visible in VE.Wed, Jun 3, 2:17 PM
Esanders claimed this task.
Esanders updated the task description. (Show Details)

I think it would be just easier to replace collapsible/collapsed with mw-collapsible/mw-collapsed on these wikis. I will raise this topic on ruwiki village pump.

It would be good to fix this too, but realistically we're going to have to support the old classes for the forseeable future.

Change #1297152 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Collapsed content: Support legacy CSS classes

https://gerrit.wikimedia.org/r/1297152