Page MenuHomePhabricator
Create Task
Maniphest T428373

Deprecate MediaWikiIntegrationTestCase::assertSelect and drop in 1.48
Open, Stalled, Needs TriagePublic
Actions

Description

Summary

MediaWikiIntegrationTestCase::assertSelect provides an unintuitive way to select rows and provides no benefit over the TestSelectQueryBuilder and is used only in 30 files. Therefore it should be deprecated and later dropped, with all code using MediaWikiIntegrationTestCase::newSelectQueryBuilder instead

Acceptance criteria

  • Uses of ::assertSelect are dropped (code search)
  • MediaWikiIntegrationTestCase::assertSelect is hard deprecated
  • MediaWikiIntegrationTestCase::assertSelect is dropped in 1.48

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
tests: Replace assertSelect() with select query builderUmherirrendermediawiki/extensions/BlueSpicePageTemplatesmaster+10 -12
tests: Replace assertSelect() with select query builderHslatermediawiki/extensions/BlueSpicePageTemplatesREL1_43+10 -12
tests: Hard-deprecate MediaWikiIntegrationTestCase::assertSelectUmherirrendermediawiki/coremaster+6 -2
tests: Replace assertSelect() with select query builderUmherirrendermediawiki/extensions/BlueSpiceRemindermaster+17 -20
tests: Replace assertSelect() with select query builderUmherirrendermediawiki/extensions/BlueSpiceReadConfirmationmaster+10 -13
tests: Replace assertSelect() with select query builderUmherirrendermediawiki/extensions/BlueSpiceRatingmaster+10 -16
tests: Replace assertSelect() with select query builderUmherirrendermediawiki/extensions/BlueSpicePageAssignmentsmaster+13 -12
tests: Replace assertSelect() with select query builderUmherirrendermediawiki/extensions/BlueSpiceExpirymaster+10 -16
tests: Replace assertSelect() with select query builderUmherirrendermediawiki/extensions/MediaUploadermaster+26 -31
tests: Replace assertSelect() with select query builderUmherirrendermediawiki/extensions/Echomaster+30 -36
tests: Replace assertSelect() with select query builderUmherirrendermediawiki/extensions/Wikispeechmaster+26 -26
tests: Replace assertSelect() with select query builderUmherirrendermediawiki/extensions/AchievementBadgesmaster+6 -7
tests: Replace assertSelect() with select query builderUmherirrendermediawiki/extensions/LDAPProvidermaster+5 -8
tests: Replace assertSelect() with select query builderUmherirrendermediawiki/extensions/CreatedPagesListmaster+9 -11
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Dreamy_Jazz created this task.Jun 7 2026, 8:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2026, 8:35 PM
gerritbot added a comment.Jun 7 2026, 8:35 PM

Change #1298026 had a related patch set uploaded (by Dreamy Jazz; author: Umherirrender):

[mediawiki/extensions/CreatedPagesList@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298026

gerritbot added a project: Patch-For-Review.Jun 7 2026, 8:35 PM

Change #1298024 had a related patch set uploaded (by Dreamy Jazz; author: Umherirrender):

[mediawiki/extensions/Echo@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298024

gerritbot added a comment.Jun 7 2026, 8:37 PM

Change #1298029 had a related patch set uploaded (by Dreamy Jazz; author: Umherirrender):

[mediawiki/extensions/Wikispeech@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298029

gerritbot added a comment.Jun 7 2026, 8:48 PM

Change #1298024 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298024

gerritbot added a comment.Jun 7 2026, 8:48 PM

Change #1298026 merged by jenkins-bot:

[mediawiki/extensions/CreatedPagesList@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298026

gerritbot added a comment.Jun 7 2026, 8:48 PM

Change #1298029 merged by jenkins-bot:

[mediawiki/extensions/Wikispeech@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298029

gerritbot added a comment.Jun 7 2026, 8:51 PM

Change #1298027 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LDAPProvider@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298027

gerritbot added a comment.Jun 7 2026, 8:52 PM

Change #1298027 merged by Umherirrender:

[mediawiki/extensions/LDAPProvider@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298027

gerritbot added a comment.Jun 7 2026, 8:52 PM

Change #1298025 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AchievementBadges@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298025

gerritbot added a comment.Jun 7 2026, 8:52 PM

Change #1298025 merged by Umherirrender:

[mediawiki/extensions/AchievementBadges@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298025

gerritbot added a comment.Jun 7 2026, 8:54 PM

Change #1298030 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MediaUploader@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298030

gerritbot added a comment.Jun 7 2026, 8:54 PM

Change #1298030 merged by Umherirrender:

[mediawiki/extensions/MediaUploader@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298030

Umherirrender mentioned this in rEABAf41b04db523f: tests: Replace assertSelect() with select query builder.Jun 7 2026, 8:54 PM
Dreamy_Jazz updated the task description. (Show Details)Jun 7 2026, 8:58 PM
Dreamy_Jazz updated the task description. (Show Details)
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.6; 2026-06-09).Jun 7 2026, 9:00 PM
Dreamy_Jazz updated the task description. (Show Details)Jun 7 2026, 9:02 PM
Umherirrender mentioned this in rELDQ657d72de7432: tests: Replace assertSelect() with select query builder.Jun 7 2026, 9:19 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 7 2026, 9:30 PM
Dreamy_Jazz assigned this task to Umherirrender.Jun 8 2026, 12:47 PM

Assuming you can create the patches for the hard deprecation? I can code review, or create the patches if you prefer

gerritbot added a comment.Jun 8 2026, 4:45 PM

Change #1298840 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Hard-deprecate MediaWikiIntegrationTestCase::assertSelect

https://gerrit.wikimedia.org/r/1298840

gerritbot added a project: Patch-For-Review.Jun 8 2026, 4:45 PM
gerritbot added a comment.Jun 8 2026, 4:56 PM

Change #1298842 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceExpiry@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298842

gerritbot added a comment.Jun 8 2026, 4:56 PM

Change #1298843 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpicePageAssignments@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298843

gerritbot added a comment.Jun 8 2026, 4:57 PM

Change #1298844 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpicePageTemplates@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298844

gerritbot added a comment.Jun 8 2026, 4:57 PM

Change #1298845 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceRating@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298845

gerritbot added a comment.Jun 8 2026, 4:57 PM

Change #1298846 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceReadConfirmation@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298846

gerritbot added a comment.Jun 8 2026, 4:57 PM

Change #1298847 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceReminder@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298847

gerritbot added a comment.Jun 8 2026, 5:11 PM

Change #1298840 merged by jenkins-bot:

[mediawiki/core@master] tests: Hard-deprecate MediaWikiIntegrationTestCase::assertSelect

https://gerrit.wikimedia.org/r/1298840

Dreamy_Jazz updated the task description. (Show Details)Jun 8 2026, 5:18 PM
gerritbot added a comment.Jun 8 2026, 5:20 PM

Change #1298842 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceExpiry@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298842

Umherirrender mentioned this in rEBUF11b1ed028ef8: tests: Replace assertSelect() with select query builder.Jun 8 2026, 5:20 PM
gerritbot added a comment.Jun 8 2026, 5:21 PM

Change #1298843 merged by jenkins-bot:

[mediawiki/extensions/BlueSpicePageAssignments@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298843

gerritbot added a comment.Jun 8 2026, 5:22 PM

Change #1298844 merged by jenkins-bot:

[mediawiki/extensions/BlueSpicePageTemplates@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298844

gerritbot added a comment.Jun 8 2026, 5:22 PM

Change #1298845 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceRating@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298845

gerritbot added a comment.Jun 8 2026, 5:22 PM

Change #1298846 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceReadConfirmation@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298846

gerritbot added a comment.Jun 8 2026, 5:22 PM

Change #1298847 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceReminder@master] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1298847

Umherirrender mentioned this in rEBUE1798e12c2ed9: tests: Replace assertSelect() with select query builder.Jun 8 2026, 5:23 PM
Umherirrender mentioned this in rEBUL277df3cc74da: tests: Replace assertSelect() with select query builder.
Umherirrender mentioned this in rEBUHc16dde7e5e14: tests: Replace assertSelect() with select query builder.
Maintenance_bot removed a project: Patch-For-Review.Jun 8 2026, 5:30 PM
Umherirrender renamed this task from Deprecate and drop MediaWikiIntegrationTestCase::assertSelect to Deprecate MediaWikiIntegrationTestCase::assertSelect and drop in 1.48.Jun 8 2026, 5:36 PM
Umherirrender changed the task status from Open to Stalled.
Umherirrender removed Umherirrender as the assignee of this task.
Umherirrender subscribed.
Dreamy_Jazz updated the task description. (Show Details)Jun 8 2026, 5:39 PM
Dreamy_Jazz updated the task description. (Show Details)

Thanks!

Dreamy_Jazz moved this task from Untriaged to 2023+ | MW 1.40+ on the Technical-Debt (Deprecation process) board.Jun 8 2026, 5:40 PM
Umherirrender unsubscribed.Jun 11 2026, 9:34 PM
Umherirrender moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jun 12 2026, 5:36 PM
gerritbot added a comment.Jun 17 2026, 5:52 PM

Change #1303503 had a related patch set uploaded (by Hslater; author: Umherirrender):

[mediawiki/extensions/BlueSpicePageTemplates@REL1_43] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1303503

gerritbot added a project: Patch-For-Review.Jun 17 2026, 5:52 PM
Dreamy_Jazz updated the task description. (Show Details)Jun 17 2026, 5:53 PM
gerritbot added a comment.Jun 17 2026, 7:19 PM

Change #1303503 merged by jenkins-bot:

[mediawiki/extensions/BlueSpicePageTemplates@REL1_43] tests: Replace assertSelect() with select query builder

https://gerrit.wikimedia.org/r/1303503

Maintenance_bot removed a project: Patch-For-Review.Jun 17 2026, 7:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits