This task is a follow-up to T407497, which introduced a refreshed logged-out warning message on mobile. During manual testing of the refreshed message, an unexpected page scroll was observed when the message is open. The suspected cause is that the message does not account for the editor toolbar height when the message renders.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| editor: Fix mobile anonwarning height and vertical centering | Urbanecm | mediawiki/extensions/MobileFrontend | master | +14 -5 |
Related Objects
Related Objects
- Mentioned Here
- T407497: Redesign the Logged-Out Warning Message on Mobile
Event Timeline
Comment Actions
With @AAlhazwani-WMF's help, I was able to reproduce this locally (with both an Android and iOS device). The problem is not visible in a simulator.
Comment Actions
Change #1308684 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[mediawiki/extensions/MobileFrontend@master] editor: Use dvh for anonwarning height to avoid page scroll
Comment Actions
Test wiki created on Patch demo by Martin Urbanec (WMF) using patch(es) linked to this task:
https://dd4753c226.catalyst.wmcloud.org/w/
Comment Actions
Change #1308684 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] editor: Fix mobile anonwarning height and vertical centering
Comment Actions
QA note: Please make sure to check this on a physical device (preferably, both iOS and Android).
Comment Actions
Checked https://dd4753c226.catalyst.wmcloud.org/w/ and enwiki beta (the patch is merged) on two real devices I have - iPhone 11 and Android Samsung Galaxy S8. Also checked on "real devices" in Browserstack.
The task, in my opinion, describes two types of scrolling issues
(1) ✅ DONE
an unexpected page scroll was observed when the message is open.
Steps:
- on an article page, anon user clicks on the pencil button
- the message is scrolling vertically when loads (it scrolls first up and then down).
That issue resolved - see the table below when it was checked.
(2) The vertical scroll of the whole page when the page of message is loaded - the screen recording shows that issue
The overall vertical scroll is still present, but the issue is not specific to the warning message display. Many other pages - e.g. Impact module, Mentorship module would have unnecessary scrolling.
| device | browser |
|---|---|
| iPhone 11 real device | Safari |
| iPhone 11 real device | Chrome |
| BrowserStack (emulator) iPhone 14 | Safari |
| BrowserStack (emulator) iPhone 14 | Chrome |
| BrowserStack (emulator) iPhone 15 | Safari |
| BrowserStack (emulator) iPhone 14 | Chrome |
| Samsung Galaxy S8 real device | Chrome |
| Samsung Galaxy S8 real device | Firefox |