Page MenuHomePhabricator
Create Task
Maniphest T428742

MediaViewer preference disappeared from Special:Preferences
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):
Go to Special:Preferences, appearance tab, on any wiki. In the 'files' section, there used to be an option to disable or enable MediaViewer. This preference is gone since some time.

Reported at https://de.wikipedia.org/w/index.php?title=Wikipedia:Technik/Werkstatt&oldid=267833474#Wo_ist_der_MV_in_den_Einstellungen_geblieben?

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Restore MediaViewer toggle in Special:PreferencesEric Gardnermediawiki/extensions/MultimediaViewerwmf/1.47.0-wmf.6+34 -0
Restore MediaViewer toggle in Special:PreferencesEric Gardnermediawiki/extensions/MultimediaViewermaster+34 -0
Customize query in gerrit

Related Objects

Event Timeline

hgzh created this task.Jun 10 2026, 12:21 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptJun 10 2026, 12:21 PM
HakanIST subscribed.Jun 10 2026, 1:17 PM

This looks like it may have been introduced in rEMMV8022a88a7efc (T426225), which removed the onGetPreferences() hook while migrating carousel preferences to BetaFeatures. The desktop multimediaviewer-enable toggle was also registered in that same method and seems to have been unintentionally removed along with it.

Johannnes89 subscribed.Jun 11 2026, 5:54 AM
Jdlrobson-WMF added a project: Reader Growth Team.Jun 11 2026, 3:51 PM
JScherer-WMF triaged this task as High priority.Jun 11 2026, 4:12 PM
JScherer-WMF moved this task from Incoming/Inbox to Needs Refinement on the Reader Growth Team board.
egardner moved this task from Needs Refinement to Sprint 6 (Jun 10 - 30) Q4 25/26 on the Reader Growth Team board.Jun 11 2026, 6:38 PM
egardner edited projects, added: Reader Growth Team (Sprint 6 (Jun 10 - 30) Q4 25/26); removed: Reader Growth Team.
gerritbot added a comment.Jun 11 2026, 6:52 PM

Change #1300890 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/extensions/MultimediaViewer@master] Restore MediaViewer toggle in Special:Preferences

https://gerrit.wikimedia.org/r/1300890

gerritbot added a project: Patch-For-Review.Jun 11 2026, 6:52 PM
egardner claimed this task.Jun 11 2026, 6:54 PM
egardner moved this task from Committed to Code Review on the Reader Growth Team (Sprint 6 (Jun 10 - 30) Q4 25/26) board.
egardner set the point value for this task to 1.
egardner added a comment.Jun 11 2026, 6:56 PM

Thanks @hgzh and @HakanIST for flagging. This regression was an unintended side-effect of another change we were doing in regards to a mobile-focused beta feature in MMV (mobile image carousel). I have a patch up which restores the erroneously-removed functionality.

egardner mentioned this in T428959: Request: Restore erroneously-pruned translations of "multimediaviewer-optin-pref".Jun 11 2026, 8:19 PM
gerritbot added a comment.Jun 11 2026, 8:22 PM

Change #1300890 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Restore MediaViewer toggle in Special:Preferences

https://gerrit.wikimedia.org/r/1300890

gerritbot added a comment.Jun 11 2026, 8:25 PM

Change #1300906 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.6] Restore MediaViewer toggle in Special:Preferences

https://gerrit.wikimedia.org/r/1300906

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.7; 2026-06-16).Jun 11 2026, 9:00 PM
gerritbot added a comment.Jun 11 2026, 9:34 PM

Change #1300906 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.6] Restore MediaViewer toggle in Special:Preferences

https://gerrit.wikimedia.org/r/1300906

Stashbot added a comment.Jun 11 2026, 9:34 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-11T21:34:27Z] <egardner@deploy1003> Started scap sync-world: Backport for [[gerrit:1300906|Restore MediaViewer toggle in Special:Preferences (T428742)]]

Stashbot added a comment.Jun 11 2026, 9:51 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-11T21:51:40Z] <egardner@deploy1003> egardner: Backport for [[gerrit:1300906|Restore MediaViewer toggle in Special:Preferences (T428742)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.6; 2026-06-09); removed: MW-1.47-notes (1.47.0-wmf.7; 2026-06-16).Jun 11 2026, 10:00 PM
Stashbot added a comment.Jun 11 2026, 10:05 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-11T22:05:18Z] <egardner@deploy1003> Finished scap sync-world: Backport for [[gerrit:1300906|Restore MediaViewer toggle in Special:Preferences (T428742)]] (duration: 30m 51s)

egardner moved this task from Code Review to QA on the Reader Growth Team (Sprint 6 (Jun 10 - 30) Q4 25/26) board.Jun 11 2026, 10:07 PM

This change has been backported and the toggle functionality should be restored in Special:Preferences.

Translations will need to be restored separately (see T428959).

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2026, 10:31 PM
hgzh closed this task as Resolved.Jun 15 2026, 6:01 AM

The preference is back, thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits