Page MenuHomePhabricator
Create Task
Maniphest T428762

Comment IDs with anchors are unreachable via Special:GoToComment
Closed, ResolvedPublicBUG REPORT
Actions

Description

What happens?:
https://ru.wikipedia.org/wiki/Википедия:Оспаривание_итогов#Википедия:К_удалению/28_декабря_2023#Sonic_Kart_3DX generates the following link for the opening message:

https://ru.wikipedia.org/wiki/Википедия:Оспаривание_итогов#c-Sleeps-Darkly-20240811163100-Википедия:К_удалению/28_декабря_2023#Sonic_Kart_3DX

This link can be reached normally for some users by going to it but if you use Special:GoToComment, which is preferable way for the longevity of links, you can no longer find it:
https://ru.wikipedia.org/wiki/Служебная:FindComment/c-Sleeps-Darkly-20240811163100-Википедия:К_удалению/28_декабря_2023#Sonic_Kart_3DX

What should have happened instead?:
Anchor sign should either be replaced with an underscore or the part after the anchor should be skipped. That should make those links permanently available via Special:GoToComment.

This issue affects Convenient-Discussions since it relies on Special:GoToComment for links.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
SpecialFindComment: Hide link to GoToComment if it has an anchorBartosz Dziewońskimediawiki/extensions/DiscussionToolsmaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

stjn created this task.Jun 10 2026, 2:51 PM
Restricted Application added subscribers: Base, Aklapper. · View Herald TranscriptJun 10 2026, 2:51 PM
stjn added a project: Convenient-Discussions.Jun 10 2026, 2:52 PM
stjn updated the task description. (Show Details)
Restricted Application added a subscriber: Jack_who_built_the_house. · View Herald TranscriptJun 10 2026, 2:52 PM
Jack_who_built_the_house added a comment.EditedJun 10 2026, 4:06 PM

I updated comment links with IDs containing # to use Special:FindComment with idorname parameter, as with T426732: DiscussionTools produces invalid fragments for topic titles with curly brackets (or other non-wgLegalTitleChars?).

As for DT, note that this link

image.png (1,101×367 px, 32 KB)

at https://ru.wikipedia.org/w/index.php?title=Special:FindComment&idorname=c-Sleeps-Darkly-20240811163100-Википедия%3AК_удалению%2F28_декабря_2023%23Sonic_Kart_3DX is not working, similar to T389741: GoToComment does not work for certain characters in comment IDs. So, I think the solution is the same: remove the note with that link.

gerritbot added a comment.Jun 11 2026, 12:59 PM

Change #1300788 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] SpecialFindComment: Hide link to GoToComment if it has an anchor

https://gerrit.wikimedia.org/r/1300788

gerritbot added a project: Patch-For-Review.Jun 11 2026, 12:59 PM
matmarex claimed this task.Jun 11 2026, 12:59 PM
gerritbot added a comment.Tue, Jun 23, 1:18 PM

Change #1300788 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] SpecialFindComment: Hide link to GoToComment if it has an anchor

https://gerrit.wikimedia.org/r/1300788

Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 23, 1:31 PM
matmarex closed this task as Resolved.Tue, Jun 23, 1:55 PM

Fixed as much as it's going to be in this task – FindComment will no longer generate non-working links to GoToComment. We can continue thinking about how to generate working links for this case on T426732.

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.9; 2026-06-30).Tue, Jun 23, 2:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits