Page MenuHomePhabricator

Message keys showing on a wbqc popup
Closed, ResolvedPublic

Description

Screenshot 2026-06-12 at 22.49.32.png (397×343 px, 50 KB)

Event Timeline

Basically adding copyright licence to an item on commons, without copyright status, you get a warning... And that warning shows a popup, which shows the above, which is missing the messages

Thanks, I can reproduce the issue on https://commons.wikimedia.org/wiki/File:PNG_Test.png (until someone removes the statement again).

image.png (800×343 px, 65 KB)

I wonder where this comes from… I don’t think we touched anything relevant here (did we accidentally break it while working on wbui2025?), but surely this can’t have been lurking unnoticed for years.

Aha, in Do not load oojs-ui for the new mobile (MEX) interface (T400325, T423901) we moved those messages from the wikibase.quality.constraints.ui RL module to the new wikibase.quality.constraints.gadget module; WikibaseMediaInfo only loads the former, but directly inserts the messages, which are now missing. Oops.

WikibaseMediaInfo only loads the former, but directly inserts the messages, which are now missing.

(After taking another look: I think at least some of the messsages are actually added by the wikibase.quality.constraints.ui module, not by WBMI, and should thus be shipped with that module as well. To be investigated when we pick up this task.)

Task Time
Spike: Determine how this error happened
Initial Timebox: 4h

Change #1304607 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Add missing messages to wikibase.quality.constraints.ui

https://gerrit.wikimedia.org/r/1304607

Change #1304611 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@master] Add WikibaseQualityConstraints messages to RL module

https://gerrit.wikimedia.org/r/1304611

Change #1304607 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Add missing messages to wikibase.quality.constraints.ui

https://gerrit.wikimedia.org/r/1304607

AudreyPenven_WMDE subscribed.

the patch for WikibaseMediaInfo is failing in CI, more work is needed to figure out exactly why, and to fix it

the patch for WikibaseMediaInfo is failing in CI, more work is needed to figure out exactly why, and to fix it

CI is green now, though the patch is somewhat ugly as a result (see the commit message for details).

Change #1304611 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Add WBQC messages to RL module if available

https://gerrit.wikimedia.org/r/1304611

TV: Looks like the proposed solution fixed the issue.
Thanks a lot!