The basic CN templates in the CN banner creator, which can be used to create a personalized banner, all have color settings that are not usable in dark mode. Going through all the different elements in the banner to manually correct the colors defies the objective of having the templates to give users a basic compatible code to start with, and to avoid simple banner errors
Description
Description
Details
Details
Related Changes in GitLab:
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| refactor: use Codex design tokens for template default colours | toolforge-repos/centralnotice-banner-editor!82 | vriaa | work/vriaa/refactor/use-codex-design-token-for-default-colors | main |
Event Timeline
Comment Actions
vriaa opened https://gitlab.wikimedia.org/toolforge-repos/centralnotice-banner-editor/-/merge_requests/82
refactor: use Codex design tokens for template default colours
Comment Actions
vriaa merged https://gitlab.wikimedia.org/toolforge-repos/centralnotice-banner-editor/-/merge_requests/82
refactor: use Codex design tokens for template default colours
Comment Actions
Hi @Ciell, thanks for flagging this.
The templates now default to tokens and no longer raise the custom colour warning.

