Page MenuHomePhabricator

Template redirects can't be used as custom licenses in UW, for example, {{PD-simple}}
Closed, ResolvedPublic

Description

Author: masatia

Description:
Hello. I tested in my desktop when I trying to upload image that is {{PD-simple}},UploadWizard blocked it and it says is a wrong license but not. It's a license tag is valid. I try many times when I try to upload it and says wrong. I might confused to Found in internet. So,I can't do it. It not occur in Old form,which that works. Please Help!


Version: unspecified
Severity: major

Details

Reference
bz40920

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:10 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz40920.
bzimport added a subscriber: Unknown Object (MLST).

Hi Ferry,
unfortunately this report is not very useful because it does not describe the problem well. If you have time and can still reproduce the problem, please read https://www.mediawiki.org/wiki/How_to_report_a_bug and add a more useful description to this report by providing exact steps to reproduce (click by click).
Also, which exact Mediawiki version is this about?

I might confused to Found in internet.

I don't understand that sentence. :(

sumanah wrote:

Andre, I think Ferry is referring to the UploadWizard license selector choices, which, if you choose "This file is not my own work", include "I found it on the Internet -- I'm not sure". So maybe Ferry has configured the local MediaWiki instance so that it doesn't allow certain license choices, and is worried that s/he has confused one of the licenses for another.

Ferry, please do answer Andre's questions and read that page. Thanks!

Ferry: Please provide steps to reproduce (click by click).
Where to you set "{{PD-simple}}"?

UploadWizard blocked it and it says is a wrong license but not.

What is the exact and complete message that is shown?

Trying myself on http://test2.wikipedia.org/wiki/Special:UploadWizard :
Under "Release rights", I choose

  • This file is not my own work.
  • I found it on the Internet -- I'm not sure I believe this work is freely licensed or legally in the public domain. I understand that if I do not add the necessary licensing information in a timely fashion, the file may be deleted.

I get asked for "Source" and "Author(s)" and everything works fine.

I see the problem (and the cause). Steps to reproduce:

  1. Open Special:UploadWizard on Commons
  2. Choose a file to upload
  3. Click 'Continue'
  4. Choose 'This file is not my own work.'
  5. Enter a Source and Author
  6. Choose 'Another reason not mentioned above'. (This is where you go to enter a custom license.)
  7. Enter '{{PD-simple}}'
  8. Click 'Continue'

The problem is that PD-simple isn't an actual template, but a redirect to PD-shape. And because of this, it isn't assigned to 'Category:PD license tags'. We need to have UploadWizard check for redirects here and follow them.

masatia wrote:

Oh yeah.I'm forgot about this...

masatia wrote:

I'm forgot about {{PD-shape}}. It's wrong,That FleetCommand Give me a "Keep and change to {{PD-simple}}",but that's wrong! FleetCommand Give me a wrong setence! That's right!

masatia wrote:

This is the error

This is my error,This is when i was as "DudeTwo".

Attached:

Capture.PNG (89×798 px, 7 KB)

masatia wrote:

Become major bug again,because license redirects won't read UploadWizard properly.

masatia wrote:

Become major bug again,because license redirects won't read by UploadWizard
properly.

masatia wrote:

Hello all,This bug makes license redirects will not read properly by UploadWizard.This is not occur in normal upload form.

masatia wrote:

Please give me a patch,please.

The bug is already marked as High priority. Spamming the bug comments won't speed things up any.

  • Bug 35901 has been marked as a duplicate of this bug. ***

(In reply to Nischay Nahata from comment #13)

https://gerrit.wikimedia.org/r/#/c/50755/

That patch is getting reviews. It is currently being -1'd by Jenkins (failing tests, needs a rebase) as of May 22nd (about a month ago).

Nischay: Are you able to continue with the work on the patch?

Gergo: Are you still working on this? I'm going to reset assignee for now but please do re-take it if you are able to work more on this.

  • Bug 67206 has been marked as a duplicate of this bug. ***

This is stuck; somebody needs to be assigned and rework the patch if this is really still "high priority".

Doesn't seem to be an issue anymore - tested on betacommons with {{blah}} which redirects to {{blah blah blah}} which is in [[Category:License tags]] - may also have been fixed because we just removed license template validation in UW.

Closing!

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:22 AM