Page MenuHomePhabricator

Link to edit TemplateData is broken with Parsoid Read Views
Closed, ResolvedPublic

Description

If you visit
https://en.wikipedia.org/w/index.php?title=Template:Citation_needed
and scroll down to the TemplateData section there's a link to "Edit Template Data":

image.png (1,406×392 px, 145 KB)

On the legacy parser this links to:
https://en.wikipedia.org/w/index.php?title=Template:Citation_needed/doc&action=edit&templatedata=edit
but on Parsoid this links to:
https://en.wikipedia.org/w/index.php?title=Template:Citation_needed&action=edit&templatedata=edit

(The trailing /doc is missing.)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
C. Scott Ananianmediawiki/coremaster+12 -6
Arlolraoperations/mediawiki-configmaster+1 -1
C. Scott Ananianmediawiki/corewmf/1.47.0-wmf.9+12 -6
C. Scott Ananianmediawiki/extensions/TemplateDatamaster+46 -0
Arlolraoperations/mediawiki-configmaster+1 -1
C. Scott Ananianmediawiki/coremaster+2 -11
C. Scott Ananianoperations/mediawiki-configmaster+7 -0
Arlolraoperations/mediawiki-configmaster+7 -0
C. Scott Ananianoperations/mediawiki-configmaster+8 -0
C. Scott Ananianoperations/mediawiki-configmaster+8 -0
C. Scott Ananianmediawiki/vendorwmf/1.47.0-wmf.8+414 -121
C. Scott Ananianmediawiki/coremaster+2 -13
C. Scott Ananianmediawiki/vendormaster+414 -121
C. Scott Ananianmediawiki/services/parsoidmaster+99 -14
C. Scott Ananianmediawiki/corewmf/1.47.0-wmf.7+95 -16
C. Scott Ananianmediawiki/corewmf/1.47.0-wmf.8+95 -16
C. Scott Ananianmediawiki/coremaster+95 -16
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

rETDA includes/Hooks.php:186 (at d96be0435c17fad10e66716001fa8cfe7d1ec65f) reads the page title as PPFrame::getTitle(), so that’s what’s wrong. I didn’t look up how that works in core, I hope you know that better than me anyways.

Change #1304681 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] [WIP] Add ExtTagPFragment type

https://gerrit.wikimedia.org/r/1304681

Change #1304682 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Pass ExtTagPFragment back to Parsoid

https://gerrit.wikimedia.org/r/1304682

Change #1304683 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/TemplateData@master] Add test case for <templatedata> included from subpage

https://gerrit.wikimedia.org/r/1304683

Change #1304928 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [parser] Always return ExtTagPFragments while preprocessing

https://gerrit.wikimedia.org/r/1304928

Change #1304682 merged by jenkins-bot:

[mediawiki/core@master] [parser] Return ExtTagPFragments while preprocessing

https://gerrit.wikimedia.org/r/1304682

Change #1305025 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@wmf/1.47.0-wmf.7] [parser] Return ExtTagPFragments while preprocessing

https://gerrit.wikimedia.org/r/1305025

Change #1305026 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@wmf/1.47.0-wmf.8] [parser] Return ExtTagPFragments while preprocessing

https://gerrit.wikimedia.org/r/1305026

Change #1305026 merged by jenkins-bot:

[mediawiki/core@wmf/1.47.0-wmf.8] [parser] Return ExtTagPFragments while preprocessing

https://gerrit.wikimedia.org/r/1305026

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:29:20Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305015|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305026|[parser] Return ExtTagPFragments while preprocessing (T429624)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:31:31Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1305015|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305026|[parser] Return ExtTagPFragments while preprocessing (T429624)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:41:53Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305015|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305026|[parser] Return ExtTagPFragments while preprocessing (T429624)]] (duration: 12m 31s)

Change #1305025 merged by jenkins-bot:

[mediawiki/core@wmf/1.47.0-wmf.7] [parser] Return ExtTagPFragments while preprocessing

https://gerrit.wikimedia.org/r/1305025

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:44:02Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305017|[parser] Add configuration to return experimental PFragment types]], [[gerrit:rGOJU130501848b37|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305025|[parser] Return ExtTagPFragments while preprocessing (T429624)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:46:11Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1305017|[parser] Add configuration to return experimental PFragment types]], [[gerrit:rGOJU130501848b37|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305025|[parser] Return ExtTagPFragments while preprocessing (T429624)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be v

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:52:30Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305017|[parser] Add configuration to return experimental PFragment types]], [[gerrit:rGOJU130501848b37|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305025|[parser] Return ExtTagPFragments while preprocessing (T429624)]] (duration: 08m 29s)

Change #1304681 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add ExtTagPFragment type to be returned by the preprocessor

https://gerrit.wikimedia.org/r/1304681

Change #1305690 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305690

Change #1305690 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305690

Change #1305711 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[operations/mediawiki-config@master] Turn on Parsoid's 'ReturnExperimentalPFragmentTypes'

https://gerrit.wikimedia.org/r/1305711

Change #1305712 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Always use HeadingPFragment and ExtTagPFragment

https://gerrit.wikimedia.org/r/1305712

Change #1305712 abandoned by C. Scott Ananian:

[mediawiki/core@master] Always use HeadingPFragment and ExtTagPFragment

Reason:

would require changes to cite parser tests which make this unfeasible as a backport

https://gerrit.wikimedia.org/r/1305712

Change #1305719 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@wmf/1.47.0-wmf.8] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305719

Change #1305719 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.47.0-wmf.8] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305719

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:36:37Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305719|Bump wikimedia/parsoid to 0.24.0-a12 (T353697 T384490 T387374 T387520 T387521 T391624 T393295 T420336 T429624 T429688 T429822)]], [[gerrit:1305720|Bump wikimedia/parsoid to 0.24.0-a12 (T429822)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:38:41Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1305719|Bump wikimedia/parsoid to 0.24.0-a12 (T353697 T384490 T387374 T387520 T387521 T391624 T393295 T420336 T429624 T429688 T429822)]], [[gerrit:1305720|Bump wikimedia/parsoid to 0.24.0-a12 (T429822)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:46:32Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305719|Bump wikimedia/parsoid to 0.24.0-a12 (T353697 T384490 T387374 T387520 T387521 T391624 T393295 T420336 T429624 T429688 T429822)]], [[gerrit:1305720|Bump wikimedia/parsoid to 0.24.0-a12 (T429822)]] (duration: 09m 54s)

Change #1305711 merged by jenkins-bot:

[operations/mediawiki-config@master] Turn on Parsoid's 'ReturnExperimentalPFragmentTypes'

https://gerrit.wikimedia.org/r/1305711

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:50:46Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305711|Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (T429624 T429822 T391624)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:52:51Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1305711|Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (T429624 T429822 T391624)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-06-25T17:42:46Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305711|Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (T429624 T429822 T391624)]] (duration: 51m 59s)

Change #1305740 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[operations/mediawiki-config@master] Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (take 2)

https://gerrit.wikimedia.org/r/1305740

Change #1305740 abandoned by C. Scott Ananian:

[operations/mediawiki-config@master] Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (take 2)

Reason:

Let's try something simpler: I8d9bec0c46775b3aaadc002f97858af943124bea

https://gerrit.wikimedia.org/r/1305740

Change #1305733 had a related patch set uploaded (by C. Scott Ananian; author: Arlolra):

[operations/mediawiki-config@master] Turn on Parsoid's 'ReturnExperimentalPFragmentTypes'

https://gerrit.wikimedia.org/r/1305733

Change #1305733 merged by jenkins-bot:

[operations/mediawiki-config@master] Turn on Parsoid's 'ReturnExperimentalPFragmentTypes'

https://gerrit.wikimedia.org/r/1305733

Mentioned in SAL (#wikimedia-operations) [2026-06-25T19:05:36Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305733|Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (T429624 T429822 T391624)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-25T19:07:28Z] <cscott@deploy1003> cscott, arlolra: Backport for [[gerrit:1305733|Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (T429624 T429822 T391624)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-06-25T19:27:43Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305733|Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (T429624 T429822 T391624)]] (duration: 22m 07s)

Change #1305746 had a related patch set uploaded (by C. Scott Ananian; author: Arlolra):

[operations/mediawiki-config@master] Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (take 2)

https://gerrit.wikimedia.org/r/1305746

Change #1305746 merged by jenkins-bot:

[operations/mediawiki-config@master] Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (take 2)

https://gerrit.wikimedia.org/r/1305746

Mentioned in SAL (#wikimedia-operations) [2026-06-25T19:52:01Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305746|Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (take 2) (T429624 T429822 T391624)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-25T19:53:30Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1305746|Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (take 2) (T429624 T429822 T391624)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-06-25T19:58:59Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305746|Turn on Parsoid's 'ReturnExperimentalPFragmentTypes' (take 2) (T429624 T429822 T391624)]] (duration: 06m 58s)

Change #1305996 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [parser] When expanding an extension tag with a title, use a new frame

https://gerrit.wikimedia.org/r/1305996

Change #1306401 had a related patch set uploaded (by Arlolra; author: Arlolra):

[operations/mediawiki-config@master] Temporarily disable experimental ExtTagPFragment type

https://gerrit.wikimedia.org/r/1306401

Change #1306401 merged by jenkins-bot:

[operations/mediawiki-config@master] Temporarily disable experimental ExtTagPFragment type

https://gerrit.wikimedia.org/r/1306401

Mentioned in SAL (#wikimedia-operations) [2026-06-29T20:09:17Z] <arlolra@deploy1003> Started scap sync-world: Backport for [[gerrit:1305724|Turn on Parsoid Read views for 5% of English Wikipedia desktop traffic (T430194)]], [[gerrit:1306401|Temporarily disable experimental ExtTagPFragment type (T430344 T429624)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-29T20:11:12Z] <arlolra@deploy1003> arlolra, cscott: Backport for [[gerrit:1305724|Turn on Parsoid Read views for 5% of English Wikipedia desktop traffic (T430194)]], [[gerrit:1306401|Temporarily disable experimental ExtTagPFragment type (T430344 T429624)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-06-29T20:22:33Z] <arlolra@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305724|Turn on Parsoid Read views for 5% of English Wikipedia desktop traffic (T430194)]], [[gerrit:1306401|Temporarily disable experimental ExtTagPFragment type (T430344 T429624)]] (duration: 13m 16s)

Reopening because the ExtTagPFragment was temporarily reverted for T430344

Change #1304683 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Add test case for <templatedata> included from subpage

https://gerrit.wikimedia.org/r/1304683

Change #1305996 merged by jenkins-bot:

[mediawiki/core@master] [parser] When expanding an extension tag with a title, use a new frame

https://gerrit.wikimedia.org/r/1305996

Change #1306996 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@wmf/1.47.0-wmf.9] [parser] When expanding an extension tag with a title, use a new frame

https://gerrit.wikimedia.org/r/1306996

Change #1306996 merged by jenkins-bot:

[mediawiki/core@wmf/1.47.0-wmf.9] [parser] When expanding an extension tag with a title, use a new frame

https://gerrit.wikimedia.org/r/1306996

Mentioned in SAL (#wikimedia-operations) [2026-07-02T07:42:45Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1307058|[REST] Don't language-convert non-parsoid output; don't lookup bogus titles (T430778)]], [[gerrit:1306996|[parser] When expanding an extension tag with a title, use a new frame (T430344 T429624)]]

Mentioned in SAL (#wikimedia-operations) [2026-07-02T07:44:51Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1307058|[REST] Don't language-convert non-parsoid output; don't lookup bogus titles (T430778)]], [[gerrit:1306996|[parser] When expanding an extension tag with a title, use a new frame (T430344 T429624)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-07-02T08:01:43Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1307058|[REST] Don't language-convert non-parsoid output; don't lookup bogus titles (T430778)]], [[gerrit:1306996|[parser] When expanding an extension tag with a title, use a new frame (T430344 T429624)]] (duration: 18m 58s)

Change #1307218 had a related patch set uploaded (by Arlolra; author: Arlolra):

[operations/mediawiki-config@master] Revert "Temporarily disable experimental ExtTagPFragment type"

https://gerrit.wikimedia.org/r/1307218

Change #1307218 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "Temporarily disable experimental ExtTagPFragment type"

https://gerrit.wikimedia.org/r/1307218

Mentioned in SAL (#wikimedia-operations) [2026-07-02T20:28:14Z] <arlolra@deploy1003> Started scap sync-world: Backport for [[gerrit:1307218|Revert "Temporarily disable experimental ExtTagPFragment type" (T430344 T429624)]], [[gerrit:1307227|Preview: Ensure ParserMigration's handler is called to setUseParsoid (T429408)]], [[gerrit:1307223|Ensure ParserMigration is consulted if Parsoid should be used (T429408)]]

Mentioned in SAL (#wikimedia-operations) [2026-07-02T20:31:07Z] <arlolra@deploy1003> cscott, arlolra: Backport for [[gerrit:1307218|Revert "Temporarily disable experimental ExtTagPFragment type" (T430344 T429624)]], [[gerrit:1307227|Preview: Ensure ParserMigration's handler is called to setUseParsoid (T429408)]], [[gerrit:1307223|Ensure ParserMigration is consulted if Parsoid should be used (T429408)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Cha

Mentioned in SAL (#wikimedia-operations) [2026-07-02T20:40:50Z] <arlolra@deploy1003> Finished scap sync-world: Backport for [[gerrit:1307218|Revert "Temporarily disable experimental ExtTagPFragment type" (T430344 T429624)]], [[gerrit:1307227|Preview: Ensure ParserMigration's handler is called to setUseParsoid (T429408)]], [[gerrit:1307223|Ensure ParserMigration is consulted if Parsoid should be used (T429408)]] (duration: 12m 35s)

Reopening because the ExtTagPFragment was temporarily reverted for T430344

Re-deployed