Page MenuHomePhabricator
Create Task
Maniphest T429688

mw-empty-elt wrapping does not take DOMFragments into account
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

$ echo "{{1x|[https://www.garesetconnexions.sncf/fr/gares-services/frmor[[Category:Page utilisant P3104]]/ La gare de Moret-Veneux-les-Sablons]}}" | php ./bin/parse.php
<p data-parsoid='{"dsr":[0,137,0,0]}'><a rel="mw:ExtLink nofollow" href="https://www.garesetconnexions.sncf/fr/gares-services/frmor" about="#mwt1" typeof="mw:Transclusion" class="external text" data-parsoid='{"pi":[[{"k":"1"}]],"dsr":[0,137,null,null]}' data-mw='{"parts":[{"template":{"target":{"wt":"1x","href":"./Template:1x"},"params":{"1":{"wt":"[https://www.garesetconnexions.sncf/fr/gares-services/frmor[[Category:Page utilisant P3104]]/ La gare de Moret-Veneux-les-Sablons]"}},"i":0}}]}'><span class="mw-empty-elt"><link rel="mw:PageProp/Category" href="./Category:Page_utilisant_P3104"/>/ La gare de Moret-Veneux-les-Sablons</span></a></p>

What happens?:

The category and the link text are wrapped into an mw-empty-elt span, which makes the text disappear when the CSS is applied.

What should have happened instead?:

The text should not be wrapped into an mw-empty-elt span.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Bump wikimedia/parsoid to 0.24.0-a12C. Scott Ananianmediawiki/vendorwmf/1.47.0-wmf.8+414 -121
Bump wikimedia/parsoid to 0.24.0-a12C. Scott Ananianmediawiki/vendormaster+414 -121
Inspect DOMFragments when stashing elements in mw-empty-elt wrappersIsabelle Hurbain-Palatinmediawiki/services/parsoidmaster+19 -1
Customize query in gerrit

Related Objects

Event Timeline

ihurbain created this task.Jun 19 2026, 2:01 PM
Restricted Application added a project: Parsoid. · View Herald TranscriptJun 19 2026, 2:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ihurbain added a comment.Jun 19 2026, 2:02 PM

This is due to the fact that the wrapping happens before DOMFragments are unwrapped; and in this case, the DOMFragment contains the category and the text, but is stored inside a category link:

$ echo "{{1x|[https://www.garesetconnexions.sncf/fr/gares-services/frmor[[Category:Page utilisant P3104]]/ La gare de Moret-Veneux-les-Sablons]}}" | php ./bin/parse.php --dump=dom:pre-tplwrap
[dump] ----- DOM: pre-tplwrap -----
<link rel="mw:PageProp/Category" href="./Category:Page_utilisant_P3104" data-parsoid='{"tsr":[59,92],"stx":"simple","a":{"href":"./Category:Page_utilisant_P3104"},"sa":{"href":"Category:Page utilisant P3104"}}'/>/ La gare de Moret-Veneux-les-Sablons
----------------------------

[dump] ----- DOM: pre-tplwrap -----
<body data-parsoid='{"dsr":[0,138,0,0]}'><p data-parsoid='{"dsr":[0,137,0,0]}'><meta typeof="mw:Transclusion" about="#mwt1" data-parsoid='{"tsr":[0,137],"src":"{{1x|[https://www.garesetconnexions.sncf/fr/gares-services/frmor[[Category:Page utilisant P3104]]/ La gare de Moret-Veneux-les-Sablons]}}","dsr":[0,137,null,null]}'/><a rel="mw:ExtLink" href="https://www.garesetconnexions.sncf/fr/gares-services/frmor" data-parsoid="{}"><link rel="mw:PageProp/Category" href="./Category:Page_utilisant_P3104" typeof="mw:DOMFragment" data-parsoid='{"stx":"simple","a":{"href":"./Category:Page_utilisant_P3104"},"sa":{"href":"Category:Page utilisant P3104"},"html":{"_h":"&lt;link rel=\"mw:PageProp/Category\" href=\"./Category:Page_utilisant_P3104\" data-parsoid=&apos;{\"tsr\":[59,92],\"stx\":\"simple\",\"a\":{\"href\":\"./Category:Page_utilisant_P3104\"},\"sa\":{\"href\":\"Category:Page utilisant P3104\"}}&apos;/>/ La gare de Moret-Veneux-les-Sablons"}}'/></a><meta typeof="mw:Transclusion/End" about="#mwt1" data-parsoid='{"tsr":[null,137],"dsr":[null,137,null,null]}'/></p>
</body>
ihurbain claimed this task.Jun 19 2026, 2:11 PM
gerritbot added a comment.Jun 19 2026, 2:18 PM

Change #1304590 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Inspect DOMFragments when stashing elements in mw-empty-elt wrappers

https://gerrit.wikimedia.org/r/1304590

gerritbot added a project: Patch-For-Review.Jun 19 2026, 2:18 PM
ihurbain moved this task from Backlog to Code Review on the Content-Platform-Team (Work In Progress) board.Jun 19 2026, 2:19 PM
gerritbot added a comment.Jun 23 2026, 12:31 AM

Change #1304590 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Inspect DOMFragments when stashing elements in mw-empty-elt wrappers

https://gerrit.wikimedia.org/r/1304590

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2026, 1:32 AM
ihurbain moved this task from Code Review to To Deploy on the Content-Platform-Team (Work In Progress) board.Jun 25 2026, 1:08 PM
gerritbot added a comment.Jun 25 2026, 2:50 PM

Change #1305690 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305690

gerritbot added a project: Patch-For-Review.Jun 25 2026, 2:50 PM
gerritbot added a comment.Jun 25 2026, 3:44 PM

Change #1305690 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305690

gerritbot added a comment.Jun 25 2026, 4:22 PM

Change #1305719 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@wmf/1.47.0-wmf.8] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305719

gerritbot added a comment.Jun 25 2026, 4:35 PM

Change #1305719 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.47.0-wmf.8] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305719

Stashbot mentioned this in T387374: Compound templates prevent section edit links where legacy adds them.Jun 25 2026, 4:36 PM
Stashbot mentioned this in T387520: Support section edit links to nested templates.
Stashbot mentioned this in T391624: Parsoid section edit link issues.
Stashbot mentioned this in T429822: CTT tasks week of 2026-06-19.
Stashbot mentioned this in T420336: mw-parsoid improvements.
Stashbot mentioned this in T429624: Link to edit TemplateData is broken with Parsoid Read Views.
Stashbot mentioned this in T387521: Section titles failing to resolve redirected templates.
Stashbot mentioned this in T353697: Parsoid/legacy parser {{Pre}} template rendering difference.

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:36:37Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305719|Bump wikimedia/parsoid to 0.24.0-a12 (T353697 T384490 T387374 T387520 T387521 T391624 T393295 T420336 T429624 T429688 T429822)]], [[gerrit:1305720|Bump wikimedia/parsoid to 0.24.0-a12 (T429822)]]

Stashbot mentioned this in T393295: Measurement plan + Analysis for the "Get Started" experiment (WE1.2.17, FY24/25).Jun 25 2026, 4:37 PM
Stashbot mentioned this in T384490: Include directives on a line with headings prevent the legacy parser from generating section edit links.

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:38:41Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1305719|Bump wikimedia/parsoid to 0.24.0-a12 (T353697 T384490 T387374 T387520 T387521 T391624 T393295 T420336 T429624 T429688 T429822)]], [[gerrit:1305720|Bump wikimedia/parsoid to 0.24.0-a12 (T429822)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 25 2026, 4:46 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:46:32Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305719|Bump wikimedia/parsoid to 0.24.0-a12 (T353697 T384490 T387374 T387520 T387521 T391624 T393295 T420336 T429624 T429688 T429822)]], [[gerrit:1305720|Bump wikimedia/parsoid to 0.24.0-a12 (T429822)]] (duration: 09m 54s)

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2026, 5:32 PM
ihurbain closed this task as Resolved.EditedJun 26 2026, 8:49 AM

Fixed on https://fr.wikipedia.org/wiki/Gare_de_Moret-Veneux-les-Sablons for this specific issue.

There's still a visual diff because there's a trailing slash in the URL that ends up in the link text, but that's an independent issue, filed in T430280.

MSantos added a project: OKR-Work.Jul 9 2026, 11:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits