| phuedx | |
| Jun 22 2026, 2:13 PM |
| F89970284: Screenshot 2026-06-22 at 15.08.40.png | |
| Jun 22 2026, 2:13 PM |
While investigating the ongoing test-kitchen/standalone-event-system-success-rate SLO budget burn, I noticed that the eventgate_validation_errors_total metric has the stream_name label. Running a Prometheus query like:
sum by(stream) (rate(eventgate_validation_errors_total{service="eventgate-analytics-external", error_type="HoistingError"}[5m])) * 60
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| [eventgate] Bump to v1.32.0, make eventgate-analytics auto-refresh stream configs | TChin | operations/deployment-charts | master | +6 -6 |
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Run ensureEventAllowedInStream before applyTransforms | repos/data-engineering/eventgate-wikimedia!36 | tchin | T429799 | master |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | tchin | T429799 [EventGate] Sanitize stream name in all metrics | |||
| Resolved | phuedx | T407642 Write a Decision Brief for creating an TK-aware EventGate instance | |||
| Declined | None | T407395 instrument still sending data after it's deactivated or deleted |
Hm! So this is just some client sent junk/spam? Interesting!
Right, and applyTransforms (which includes hoisting logic) is happening before ensureEventAllowedInStream.
And, we have to do that, because the setWikimediaDefaults Transform allows for setting meta.stream via a query param.
@tchin, I recall that we decided not to break apart makeSetWikimediaDefaults into different transform functions for simplicity, and because some of the logic in there had ordering dependencies. I wonder, could we perhaps extract the logic to set meta.stream and $schema out of a 'transform function' and just make it a 'hardcoded' feature in makeWikimediaValidate? Then there we could do things in this order:
tchin opened https://gitlab.wikimedia.org/repos/data-engineering/eventgate-wikimedia/-/merge_requests/36
Run ensureEventAllowedInStream before applyTransforms
tchin merged https://gitlab.wikimedia.org/repos/data-engineering/eventgate-wikimedia/-/merge_requests/36
Run ensureEventAllowedInStream before applyTransforms
Change #1324331 had a related patch set uploaded (by TChin; author: TChin):
[operations/deployment-charts@master] [eventgate] Bump to v1.32.0, make eventgate-analytics auto-refresh stream configs
Change #1324331 merged by jenkins-bot:
[operations/deployment-charts@master] [eventgate] Bump to v1.32.0, make eventgate-analytics auto-refresh stream configs