Page MenuHomePhabricator

Obsolete Sprint extension settings in projects.fields database config value
Closed, ResolvedPublic

Description

https://phabricator.wikimedia.org/config/edit/projects.fields/ seems to list definitions from the long gone custom Sprint extension:

	"isdc:sprint:startdate": {
		"key": "isdc:sprint:startdate",
		"disabled": false
	},
	"isdc:sprint:enddate": {
		"key": "isdc:sprint:enddate",
		"disabled": false
	},
	"isdc:sprint:issprint": {
		"key": "isdc:sprint:issprint",
		"disabled": false
	}

These duplicate the more modern std:project:* definitions, defined via https://phabricator.wikimedia.org/config/edit/projects.custom-field-definitions/

Should edit the database value and remove them.

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Add 'projects.fields' config from production databaserepos/phabricator/deployment!117aklapperaklapper-wmf/T429866wmf/stable
Customize query in GitLab

Event Timeline

Aklapper triaged this task as Low priority.

Dropped the DB values (except for the issprint boolean scsOmkpB9Tqi) in T433004.

Last TODO: Remove database value via ./bin/config delete --database projects.fields, so Phab reads the local config instead.
See https://phabricator.wikimedia.org/config/edit/projects.fields/

aklapper@phab1004:~$ cd /srv/phab/phabricator/
aklapper@phab1004:/srv/phab/phabricator$ sudo ./bin/config set projects.fields --stdin < /home/aklapper/T429866.json
Reading value from stdin...
 OVERRIDDEN  The configuration key "projects.fields" is already defined in the database. The value from the database will override the value in local storage.
 DONE  Wrote configuration key "projects.fields" to local storage (in file "conf/local/local.json").

Docs are at https://we.phorge.it/book/phorge/article/configuration_locked/

FYI database config to get rid of in this ticket:

aklapper@phab1004:/srv/phab/phabricator$ sudo ./bin/config get projects.fields
{
	"config": [
		{
			"key": "projects.fields",
			"source": "local",
			"value": null,
			"status": "unset",
			"errorInfo": null
		},
		{
			"key": "projects.fields",
			"source": "database",
			"value": {
				"std:project:internal:description": {
					"key": "std:project:internal:description",
					"disabled": false
				},
				"std:project:custom:repository": {
					"key": "std:project:custom:repository",
					"disabled": false
				},
				"std:project:sprint:start": {
					"key": "std:project:sprint:start",
					"disabled": false
				},
				"std:project:sprint:end": {
					"key": "std:project:sprint:end",
					"disabled": false
				},
				"isdc:sprint:startdate": {
					"key": "isdc:sprint:startdate",
					"disabled": false
				},
				"isdc:sprint:enddate": {
					"key": "isdc:sprint:enddate",
					"disabled": false
				},
				"isdc:sprint:issprint": {
					"key": "isdc:sprint:issprint",
					"disabled": false
				}
			},
			"status": "set",
			"errorInfo": null
		}
	]
}
aklapper@phab1005:/srv/deployment/phabricator/deployment/phabricator$ sudo ./bin/config delete --database projects.fields
Deleted 'projects.fields' from database configuration.