Steps to replicate the issue (include links if applicable):
What happens?:
The icon for the search button changes every time CodeMirror is toggled.
What should have happened instead?:
The icon should remain unchanged.
Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
This is related to the recent icon updates.
Change #1305613 had a related patch set uploaded (by Zaidusyy; author: Zaidusyy):
[mediawiki/extensions/CodeMirror@master] CodeMirror: Match WikiEditor search button icon
Change #1305613 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] CodeMirror: Match WikiEditor search button icon
Change #1307461 had a related patch set uploaded (by Zaidusyy; author: Zaidusyy):
[mediawiki/extensions/CodeMirror@master] Fix CodeMirror toolbar icons scaling mismatch
Thanks @Bhsd for catching this! I looked into it and the SVG itself is exactly the same for both. The issue is just a missing CSS property: CodeMirror's CSS mask was missing mask-size, so it was rigidly stuck at 20px, whereas WikiEditor's button scales dynamically.
I've just submitted a quick follow-up patch to add mask-size: contain, which makes them scale identically
Change #1307461 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Fix CodeMirror toolbar icons scaling mismatch