Convertreference Suggestion is showing unexpectedly for a non-bare-URL
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Quiddity
	Jun 24 2026, 8:20 PM

Project Tags

Referenced Files

	F92346287: image.png
	Jul 8 2026, 1:11 AM

	F92346114: image.png
	Jul 8 2026, 1:11 AM

	F90325900: image.png
	Jun 24 2026, 8:20 PM

Subscribers

Description

Steps to replicate the issue:

Go to https://en.wikipedia.org/w/index.php?title=ISO_4217&veaction=edit

What happens?:

A Convertreference suggestion is shown

What should have happened instead?:

No suggestion should be shown, because we configured it to only show for pure "Bare URL" refs in T413279: Convert Reference Suggestion - restrict to references that are just a link

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
ConvertReferenceEditCheck: add tests	DLynch	mediawiki/extensions/VisualEditor	master	+142 -1
ConvertReferenceEditCheck: catch numbered links at covered strictness	DLynch	mediawiki/extensions/VisualEditor	master	+12 -11
ConvertReferenceEditCheck: for url-only the URL has to cover the range	DLynch	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T413279: Convert Reference Suggestion - restrict to references that are just a link

Event Timeline

Quiddity created this task.Jun 24 2026, 8:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2026, 8:20 PM

Maintenance_bot added a project: VisualEditor.Jun 24 2026, 8:29 PM

Change #1305502 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] ConvertReferenceEditCheck: for url-only the URL has to cover the range

https://gerrit.wikimedia.org/r/1305502

gerritbot added a project: Patch-For-Review.Jun 24 2026, 8:48 PM

This reference is: <ref>UNECE. (1996, December 31). Recommendation 9: Alphabetical code for the representation of currencies. (ECE/TRADE/203). United Nations. https://unece.org/trade/documents/alphabetical-code-representation-currencies</ref>. The test for whether the bare reference contained only a URL had a loophole -- because the URL wasn't linked, it was letting it through.

DLynch moved this task from Decision to be made to Code review on the Editing-team (Editing-Q4-22Jun-3Jul-2026) board.Jun 24 2026, 8:51 PM

Change #1305508 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] ConvertReferenceEditCheck: add tests

https://gerrit.wikimedia.org/r/1305508

Change #1305509 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] ConvertReferenceEditCheck: catch numbered links at covered strictness

https://gerrit.wikimedia.org/r/1305509

Change #1305502 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ConvertReferenceEditCheck: for url-only the URL has to cover the range

https://gerrit.wikimedia.org/r/1305502

Change #1305508 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ConvertReferenceEditCheck: add tests