Page MenuHomePhabricator

Add utfnormal to Codesearch
Closed, ResolvedPublic

Description

The library is used by core, and it would be useful if it was included in Codesearch so it's easier to review changes like https://gerrit.wikimedia.org/r/c/utfnormal/+/1304670

Repo: https://gerrit.wikimedia.org/r/q/project:utfnormal

Details

Related Changes in Gerrit:

Event Timeline

Change #1305972 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[labs/codesearch@master] write_config: Add utfnormal

https://gerrit.wikimedia.org/r/1305972

Change #1305972 merged by Dzahn:

[labs/codesearch@master] write_config: Add utfnormal

https://gerrit.wikimedia.org/r/1305972

Is it working? I wanted to confirm that there was actually no human action needed beyond merging.. if we just wait for the timer to run that rewrites the config.

I just wasn't entirely sure if we also had to do a service restart.

Is it working? I wanted to confirm that there was actually no human action needed beyond merging.. if we just wait for the timer to run that rewrites the config.

I just wasn't entirely sure if we also had to do a service restart.

Yes, it worked the day after it was merged (as expected); e.g. https://codesearch.wmcloud.org/search/?q=utfnormal&files=&excludeFiles=&repos=utfnormal

Cool, so if you did not have to ping anyone else, great :) Love it.