The library is used by core, and it would be useful if it was included in Codesearch so it's easier to review changes like https://gerrit.wikimedia.org/r/c/utfnormal/+/1304670
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| write_config: Add utfnormal | SomeRandomDeveloper | labs/codesearch | master | +1 -0 |
Event Timeline
Comment Actions
Change #1305972 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):
[labs/codesearch@master] write_config: Add utfnormal
Comment Actions
Change #1305972 merged by Dzahn:
[labs/codesearch@master] write_config: Add utfnormal
Comment Actions
Is it working? I wanted to confirm that there was actually no human action needed beyond merging.. if we just wait for the timer to run that rewrites the config.
I just wasn't entirely sure if we also had to do a service restart.
Comment Actions
Yes, it worked the day after it was merged (as expected); e.g. https://codesearch.wmcloud.org/search/?q=utfnormal&files=&excludeFiles=&repos=utfnormal