Page MenuHomePhabricator
Create Task
Maniphest T430456

"Cannot find module '@typescript-eslint/eslint-plugin'" on mediawiki-node24
Open, HighPublic
Actions

Assigned To
None
Authored By
Reedy
Jun 28 2026, 2:46 PM
Project Tags
Referenced Files
None
Subscribers
Aklapper
Jdforrester-WMF
• matmarex
Reedy
SomeRandomDeveloper

Description

Same as T430413: timeline mediawiki-node24 failure on REL1_45, but for multiple other repos on MW-1.44-release and MW-1.45-release

https://integration.wikimedia.org/ci/job/mediawiki-node24/41154/console

15:44:30 + exec docker run --volume /srv/jenkins/workspace/mediawiki-node24/src:/src --volume /srv/jenkins/workspace/mediawiki-node24/cache:/cache --volume /srv/jenkins/workspace/mediawiki-node24/log:/log --security-opt seccomp=unconfined --init --rm --label jenkins.job=mediawiki-node24 --label jenkins.build=41154 --env-file /dev/fd/63 docker-registry.wikimedia.org/releng/node24-test:24.18.0
15:44:30 ++ set +x
15:44:30 + set +x
15:44:30 + node --version
15:44:30 v24.18.0
15:44:30 + npm --version
15:44:30 11.16.0
15:44:30 + '[' -e package-lock.json ']'
15:44:30 + npm ci
15:44:33 npm warn deprecated glob@7.1.7: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
15:44:33 npm warn deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
15:44:33 npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
15:44:35 npm warn deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
15:44:35 
15:44:35 added 340 packages, and audited 341 packages in 5s
15:44:35 
15:44:35 81 packages are looking for funding
15:44:35   run `npm fund` for details
15:44:35 
15:44:35 3 moderate severity vulnerabilities
15:44:35 
15:44:35 To address all issues (including breaking changes), run:
15:44:35   npm audit fix --force
15:44:35 
15:44:35 Run `npm audit` for details.
15:44:36 + npm run-script test
15:44:36 
15:44:36 > test
15:44:36 > grunt test
15:44:36 
15:44:36 Running "eslint:all" (eslint) task
15:44:37 Warning: Failed to load plugin '@typescript-eslint' declared in '.eslintrc.json » eslint-config-wikimedia#overrides[2] » ./typescript': Cannot find module '@typescript-eslint/eslint-plugin'
15:44:37 Require stack:
15:44:37 - /src/__placeholder__.js
15:44:37 Referenced from: /src/node_modules/eslint-config-wikimedia/typescript.js Use --force to continue.

This is starting to feel like a wider spread issue... :(

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Update eslint-config-wikimedia to 0.32.4 on REL1_45repos/ci-tools/libup-config!137matmarexmatmarex-main-patch-61937main
Customize query in GitLab

Related Objects

Event Timeline

Reedy created this task.Jun 28 2026, 2:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2026, 2:47 PM
Reedy added projects: MediaWiki-extensions-SecureLinkFixer, MW-1.43-release, MW-1.44-release, MW-1.45-release.Jun 28 2026, 2:47 PM
Reedy updated the task description. (Show Details)
Reedy removed a project: MW-1.43-release.
Reedy updated the task description. (Show Details)
Reedy added a project: SyntaxHighlight.Jun 29 2026, 9:51 AM
Reedy updated the task description. (Show Details)
SomeRandomDeveloper subscribed.Jun 29 2026, 9:54 AM
Reedy added a project: AbuseFilter.Jun 29 2026, 10:20 AM
Reedy added a project: MediaWiki-extensions-CentralAuth.Jun 29 2026, 12:33 PM
Restricted Application added a project: MediaWiki-Core-Platform-Team. · View Herald TranscriptJun 29 2026, 12:33 PM
SomeRandomDeveloper added a project: MediaWiki-extensions-UrlShortener.Jun 29 2026, 2:07 PM
Reedy triaged this task as High priority.Jun 29 2026, 2:13 PM
OWresch-WMF moved this task from Inbox, needs triage to Kanban on the MediaWiki-Core-Platform-Team board.Jun 29 2026, 2:45 PM
OWresch-WMF edited projects, added: MediaWiki-Core-Platform-Team (Kanban); removed: MediaWiki-Core-Platform-Team.
OWresch-WMF moved this task from Essential Work to Next on the MediaWiki-Core-Platform-Team (Kanban) board.
• matmarex subscribed.EditedJun 29 2026, 2:48 PM

I saw the same issue on Friday when backporting OAuth patches: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OAuth/+/1305781/comments/337b7a7e_f425dc8c (I thought it only affected that repo)

There was a weird CI failure on this branch:

Running "eslint:all" (eslint) task
Warning: Failed to load plugin '@typescript-eslint' declared in '.eslintrc.json » eslint-config-wikimedia/server » ./common#overrides[2] » ./typescript': Cannot find module '@typescript-eslint/eslint-plugin'
Require stack:
- /src/__placeholder__.js
Referenced from: /src/node_modules/eslint-config-wikimedia/typescript.js Use --force to continue.

I don't know why that happens, but this fixes it. We use eslint-config-wikimedia 0.32.3 on the REL1_46 branch.

In that case updating eslint-config-wikimedia to 0.32.3 fixed it. I don't know what actually caused it. (It could be just a buggy package, but I also wondered if it's a CI problem similar to T429824 somehow.)

• matmarex added a subscriber: Jdforrester-WMF.Jun 29 2026, 3:00 PM

I wonder if we could run LibUp to bump eslint-config-wikimedia for all extensions on all release branches?

gerritbot added a comment.Jul 3 2026, 1:58 AM

Change #1307272 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/UrlShortener@REL1_45] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1307272

gerritbot added a project: Patch-For-Review.Jul 3 2026, 1:58 AM
gerritbot added a comment.Jul 3 2026, 2:00 AM

Change #1307273 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/UrlShortener@REL1_44] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1307273

gerritbot added a comment.Jul 3 2026, 2:02 AM

Change #1307274 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/UrlShortener@REL1_43] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1307274

gerritbot added a comment.Jul 3 2026, 2:05 AM

Change #1307272 merged by jenkins-bot:

[mediawiki/extensions/UrlShortener@REL1_45] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1307272

gerritbot added a comment.Jul 3 2026, 2:11 AM

Change #1307273 merged by jenkins-bot:

[mediawiki/extensions/UrlShortener@REL1_44] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1307273

gerritbot added a comment.Jul 3 2026, 2:14 AM

Change #1307274 merged by Krinkle:

[mediawiki/extensions/UrlShortener@REL1_43] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1307274

Maintenance_bot removed a project: Patch-For-Review.Jul 3 2026, 2:30 AM
gerritbot added a comment.Jul 9 2026, 9:13 PM

Change #1309298 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/CentralAuth@REL1_45] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1309298

gerritbot added a project: Patch-For-Review.Jul 9 2026, 9:13 PM
gerritbot added a comment.Jul 9 2026, 9:23 PM

Change #1309298 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@REL1_45] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1309298

Maintenance_bot removed a project: Patch-For-Review.Jul 9 2026, 9:30 PM
thiemowmde mentioned this in T432015: FlaggedRevs 1.45 branch CI blocked by node failure.Jul 20 2026, 1:28 PM
thiemowmde mentioned this in T431138: [MediaSearch] Failed to load plugin '@typescript-eslint' declared in '.eslintrc.json.
SomeRandomDeveloper added a project: SiteMatrix.Jul 25 2026, 9:13 AM
SomeRandomDeveloper added a project: WikiLove.Jul 25 2026, 2:16 PM
gerritbot added a comment.Jul 25 2026, 2:21 PM

Change #1316938 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/TemplateSandbox@REL1_45] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1316938

gerritbot added a project: Patch-For-Review.Jul 25 2026, 2:21 PM
SomeRandomDeveloper added a project: MediaWiki-extensions-TemplateSandbox.Jul 25 2026, 2:22 PM
CodeReviewBot added a comment.Jul 25 2026, 8:54 PM

matmarex opened https://gitlab.wikimedia.org/repos/ci-tools/libup-config/-/merge_requests/137

Update eslint-config-wikimedia to 0.32.4 on REL1_45

gerritbot added a comment.Jul 25 2026, 8:58 PM

Change #1316938 merged by jenkins-bot:

[mediawiki/extensions/TemplateSandbox@REL1_45] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1316938

CodeReviewBot added a comment.Jul 27 2026, 9:44 AM

jforrester merged https://gitlab.wikimedia.org/repos/ci-tools/libup-config/-/merge_requests/137

Update eslint-config-wikimedia to 0.32.4 on REL1_45

Maintenance_bot removed a project: Patch-For-Review.Jul 27 2026, 10:32 AM
gerritbot added a comment.Jul 27 2026, 2:38 PM

Change #1318160 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/WikimediaCampaignEvents@REL1_45] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1318160

gerritbot added a project: Patch-For-Review.Jul 27 2026, 2:38 PM
Daimona added a project: WikimediaCampaignEvents.Jul 27 2026, 2:38 PM
Restricted Application added a project: Connection-Team. · View Herald TranscriptJul 27 2026, 2:38 PM
siebrand added projects: MediaWiki-extensions-TwnMainPage, affects-translatewiki.net.Jul 27 2026, 3:38 PM
gerritbot added a comment.Jul 28 2026, 12:40 AM

Change #1318160 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCampaignEvents@REL1_45] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1318160

Daimona mentioned this in rEWCE199507040741: build: Unbreak typescript-eslint plugin in CI.Jul 28 2026, 12:41 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 28 2026, 1:31 AM
gerritbot added a comment.Jul 30 2026, 2:18 PM

Change #1319501 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@REL1_45] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1319501

gerritbot added a project: Patch-For-Review.Jul 30 2026, 2:19 PM
gerritbot added a comment.Jul 30 2026, 2:24 PM

Change #1319501 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@REL1_45] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1319501

Maintenance_bot removed a project: Patch-For-Review.Jul 30 2026, 2:32 PM
• matmarex added a comment.Jul 30 2026, 4:19 PM

I don't understand why the libup-config change hasn't resulted in any automatic dependency updates, as far as I can see. Does someone need to kick it off manually?

Jdforrester-WMF added a comment.EditedJul 30 2026, 4:54 PM

Per https://libraryupgrader.toolforge.org/status?branch=REL1_45 none of the four canary repos have upgraded yet; I think non-master branches go every week.

The last runs for the four repos on REL1_45 are:

So, theoretically, this should generally get "fixed" (i.e. there'll be loads of LibUp patches for us to manually merge in REL1_45) this coming weekend.

gerritbot added a comment.Jul 31 2026, 6:16 PM

Change #1279508 had a related patch set uploaded (by Krinkle; author: Libraryupgrader):

[VisualEditor/VisualEditor@REL1_45] build: Updating npm dependencies

https://gerrit.wikimedia.org/r/1279508

gerritbot added a project: Patch-For-Review.Jul 31 2026, 6:16 PM
gerritbot added a comment.Jul 31 2026, 6:47 PM

Change #1279508 merged by jenkins-bot:

[VisualEditor/VisualEditor@REL1_45] build: Updating npm dependencies

https://gerrit.wikimedia.org/r/1279508

gerritbot added a comment.Jul 31 2026, 7:04 PM

Change #1279504 had a related patch set uploaded (by Krinkle; author: Libraryupgrader):

[VisualEditor/VisualEditor@REL1_43] build: Updating npm dependencies

https://gerrit.wikimedia.org/r/1279504

gerritbot added a comment.Jul 31 2026, 9:15 PM

Change #1279504 merged by jenkins-bot:

[VisualEditor/VisualEditor@REL1_43] build: Updating npm dependencies

https://gerrit.wikimedia.org/r/1279504

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2026, 9:30 PM
Dragoniez moved this task from Backlog to Internal bugs on the AbuseFilter board.Aug 1 2026, 9:24 PM
• matmarex added a comment.Aug 29 2026, 2:20 PM
In T430456#12172204, @Jdforrester-WMF wrote:

Per https://libraryupgrader.toolforge.org/status?branch=REL1_45 none of the four canary repos have upgraded yet; I think non-master branches go every week.

Current status: "100% of 4 canaries and 2% of all 770 repositories have been updated."

gerritbot added a comment.Sep 5 2026, 1:15 AM

Change #1336249 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/WikibaseCirrusSearch@REL1_45] Unbreak CI

https://gerrit.wikimedia.org/r/1336249

gerritbot added a project: Patch-For-Review.Sep 5 2026, 1:15 AM
gerritbot added a comment.Sep 5 2026, 1:19 AM

Change #1336256 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/CirrusSearch@REL1_45] build: Unbreak typescript-eslint plugin in CI

https://gerrit.wikimedia.org/r/1336256

SomeRandomDeveloper added a comment.Sep 6 2026, 12:07 AM
In T430456#12268138, @matmarex wrote:
In T430456#12172204, @Jdforrester-WMF wrote:

Per https://libraryupgrader.toolforge.org/status?branch=REL1_45 none of the four canary repos have upgraded yet; I think non-master branches go every week.

Current status: "100% of 4 canaries and 2% of all 770 repositories have been updated."

Looks like it's finally making some progress now:

100% of 4 canaries and 22% of all 769 repositories have been updated.

gerritbot added a comment.Sep 6 2026, 12:07 AM

Change #1336249 abandoned by SomeRandomDeveloper:

[mediawiki/extensions/WikibaseCirrusSearch@REL1_45] Unbreak CI

Reason:

Done in 1316939

https://gerrit.wikimedia.org/r/1336249

gerritbot added a comment.Sun, Sep 6, 3:14 PM

Change #1336256 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@REL1_45] Unbreak CI

https://gerrit.wikimedia.org/r/1336256

Maintenance_bot removed a project: Patch-For-Review.Sun, Sep 6, 3:30 PM
• matmarex added a comment.Tue, Sep 29, 12:49 PM

Current status:

100% of 4 canaries and 88% of all 770 repositories have been updated.

I think it might be stuck here for a while, possibly forever (until we retire 1.45). The remaining repositories have other build failures and seem to be poorly maintained. There are about 80 other repos with problems.

For example, I just resolved the build failure blocking this in the Josa extension, which was reported back in August (T434272).

The MediaSearch extension seems to have something else causing a very similar "Cannot find module '@typescript-eslint/eslint-plugin'" error (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaSearch/+/1304199). I haven't investigated it.

Restricted Application added a project: Product Safety and Integrity. · View Herald TranscriptTue, Sep 29, 12:49 PM
Dreamy_Jazz removed a project: Product Safety and Integrity.Tue, Sep 29, 1:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits