Page MenuHomePhabricator

Collection should process redirects
Closed, ResolvedPublic

Description

Example:

The book https://de.wikipedia.org/wiki/Benutzer:Wikinaut/B%C3%BCcher/Dresden
was created some years ago. Now one of the articles making that book has been changed in the meantime.

Rendering the book now results in that page missing. i.e. the redirect not being processed but resulting in text (PDF and epub)

"Elbehochwasser 2002

  1. WEITERLEITUNG Elbhochwasser 2002"

Version: unspecified
Severity: enhancement
See Also:
http://web.archive.org/web/20100102061843/http://code.pediapress.com/wiki/ticket/615

Details

Reference
bz41046

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:49 AM
bzimport added a project: Collection.
bzimport set Reference to bz41046.
bzimport added a subscriber: Unknown Object (MLST).

Confirming. The created PDF includes the lines:

Elbehochwasser 2002
1. WEITERLEITUNG Elbhochwasser 2002

and afterwards the next article starts. No content of the "Elbehochwasser 2002" article included at all.

Not sure why I was put on CC, Andre. I guess that when one does some maintenance to an extension, one is regarded as the cause of all future bugs, or instantly promoted to maintainer :).

Anyway, I guess that Collection has never supported redirects, so that this behavior is unspecified. I'll leave this to the PediaPress people to confirm.

If this is indeed the case, this issue should be treated as an enhancement request along the lines of "When a redirected page is part of a book, the redirect target should be in all rendered versions".

Siebrand:

E:Collection *must* in my view be capable to treat redirects. Users store books, and other users move articles - book collectors will not be able to follow all these "moves" in due time.

So, actually, this appears to be an enhancement bug

reverted your recent change on my book (to keep it as a test case like described above).

I've updated the issue summary to be more concise.

(In reply to comment #3)

E:Collection *must* in my view be capable to treat redirects. Users store
books, and other users move articles - book collectors will not be able to
follow all these "moves" in due time.

That's a matter of view. We can hopefully agree to disagree as I don't think continuing this path is productive.

In any case, PediaPress is responsible for maintenance on the Collection extension. I'll not be participating in product management of development of new features for the extension. There are 64 other open issues on the Collection extension that may compete for the little attention it is given.

(In reply to comment #4)

reverted your recent change on my book (to keep it as a test case like
described above).

I think that's unwise, because as you stated, your book is now broken and the test case is very easy to reproduce.

Hi, you are very strict... but accept your points. The book is repaired now, and I like the new big title.

Hi, we are exploring a fix that will follow redirects if no explicit revision is stored in the collection. The fix seems to be quite simple, but we need a few days to make sure that it does not produce any unwanted side effects.

volker.haas wrote:

Bug seems to be fixed with the latest changes to the Collection Extension (the original example is now working)

Not working on https://de.wikipedia.org/wiki/Benutzer:Wikinaut/B%C3%BCcher/Dresden .

Perhaps de-wikipedia is not yet running the current E:Collection version ?

Apparently an older version of it:

Collection (Version 1.6.1) (9f37005)

Fri, 21 Sep 2012 21:49:20 +0100XSelect timezone: (20:49 +0000)

volker.haas wrote:

I apparently got tricked into thinking this would have been fixed, since the original saved collection was modified (and the Collection Extension contained changes that seemed to indicate a fix)...

(In reply to Nemo from comment #14)

https://de.wikipedia.org/w/index.php?title=Spezial:
Buch&bookcmd=render_collection&colltitle=Benutzer:Wikinaut/B%C3%BCcher/
Dresden&writer=rdf2latex is 488 MB... 237 pages and no WEITERLEITUNG
anywhere, can we call this fixed by OCG/new PDF renderer or am I looking in
the wrong place?

Currently, I cannot confirm that the bug is solved, the reason is that the book collection has been corrected NOT to make use of articles which are redirected.

So, in order to check whether the issue is solved or not, you have to construct a short book collection with at least one article which involves a REDIRECT. Then render as PDF and look, whether the REDIRECTion is actually performed by Extension:Collection, or whether the collection shows an empty page with the Text

Elbehochwasser 2002

  1. WEITERLEITUNG Elbhochwasser 2002

I don't want to change the (working) Dresden-Buch collection, so please can I ask you to prepare a test collection for testing this issue/solution?

I go to https://de.wikipedia.org/wiki/Benutzer:Wikinaut/B%C3%BCcher/Dresden and click "PDF". The result does include the content of the article "Hochwasser in Mitteleuropa 2002" which is redirected from "Elbehochwasser 2002".

So the problem does not happen on Wikipedia anymore (due to OCG?). Wondering what that means for this task and its priority though?

@Aklapper: yes,confirmed. The problem appears to be solved now. (pls. close the issue).

Nemo_bis set Security to None.