Page MenuHomePhabricator

Add accessible view for adding, selecting and editing profile
Open, Needs TriagePublic

Description

As of right now the view for selecting what profile the user wants to work on looks like this:

image.png (2,075×801 px, 46 KB)

However, its not for example clear that the user must click on the profile-card to be able to click next. Better would be to have radiobuttions next to the card to indicate a user choice. This is standard design in accessibility to indicate to the user that they have to make a choice.

A design proposal for this lies in this spike: T429328 - Investigate and propose design of the profile view

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Add first step of picking profilerepos/wmse/wikispeech/speech-data-collector!9viktoriahillerudwmsepick-profile-stepmain
Customize query in GitLab

Event Timeline

One interesting thing regarding radio buttons: they were already present in the code, but hidden with a sr-only CSS class. That means only screen readers could detect them. Visually, the only indication of which profile was selected was the background color changing from grey to blue, which is a known accessibility failure (WCAG 1.4.1) since it relies solely on color to communicate selection state.

The upcoming fix makes the radio buttons visible to all users, addressing both issues at once.

When you add a profile, the new design doesn't fit in the sidebar.

image.png (945×1,139 px, 101 KB)

I wonder if we even want to show the profile list in this view. The version you get on mobile, with the back button, should work fine here too.

I don't think the delete button should be primary. It shouldn't that be the action you're most likely to take. Also we'll end up with multiple primary buttons if you add more profiles.

When you add a profile, the new design doesn't fit in the sidebar.

image.png (945×1,139 px, 101 KB)

I wonder if we even want to show the profile list in this view. The version you get on mobile, with the back button, should work fine here too.

Ah yes, this is intentional not included in this first MR, and I thought I will go on the next step when that is merged.

The idea later is that this step will look as what we decided in PenPot:

image.png (665×735 px, 75 KB)

So it's true that the left column should not even be shown even on desktop
.

I also wrote that in the MR description, but I realize that could've been described here as well..

Viktoria_Hillerud_WMSE renamed this task from Add accessible view for adding and selecting profile to Add accessible view for adding, selecting and editing profile.Wed, Sep 9, 8:54 AM