Page MenuHomePhabricator
Create Task
Maniphest T430645

Update PHPat to the latest version
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

We're currently using 0.11.x in Wikibase, and at the time of writing this the latest version is 0.12.4. The rule syntax seems to have change a bit in 0.12 so we should update our tests to use that.

phpat and phpstan libraries should be updated to the latest version in Wikibase and WikibaseLexeme. There will likely be breaking changes due to the deprecation of assertions currently used in architecture tests.

WikibaseLexeme requires Wikibase to be updated first (NamedDeclaration error if WikibaseLexeme updated first).

https://github.com/carlosas/phpat

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update PHPat versionKim.phammediawiki/extensions/Wikibasemaster+39 -20
Update PHPat to latest versionKim.phammediawiki/extensions/WikibaseLexememaster+11 -6
Customize query in gerrit

Event Timeline

Jakob_WMDE created this task.Jun 30 2026, 10:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2026, 10:53 AM
kimpham updated the task description. (Show Details)Jun 30 2026, 2:06 PM
Silvan_WMDE moved this task from Tech backlog to Polished on the Wikibase Reuse Team board.Jul 22 2026, 12:32 PM
Silvan_WMDE set the point value for this task to 5.Jul 28 2026, 12:22 PM
Silvan_WMDE moved this task from Polished to Ready for planning on the Wikibase Reuse Team board.
Ifrahkhanyaree_WMDE moved this task from Ready for planning to Sprint 75 on the Wikibase Reuse Team board.Aug 5 2026, 9:28 AM
Ifrahkhanyaree_WMDE edited projects, added: Wikibase Reuse Team (Sprint 75); removed: Wikibase Reuse Team.
kimpham claimed this task.Aug 10 2026, 8:49 AM
kimpham moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 75) board.
gerritbot added a comment.Wed, Aug 12, 11:59 AM

Change #1324698 had a related patch set uploaded (by Kim.pham; author: Kim.pham):

[mediawiki/extensions/Wikibase@master] Update PHPat version

https://gerrit.wikimedia.org/r/1324698

gerritbot added a project: Patch-For-Review.Wed, Aug 12, 11:59 AM
gerritbot added a comment.Wed, Aug 12, 12:54 PM

Change #1324708 had a related patch set uploaded (by Kim.pham; author: Kim.pham):

[mediawiki/extensions/WikibaseLexeme@master] Update PHPat to latest version

https://gerrit.wikimedia.org/r/1324708

kimpham moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 75) board.Thu, Aug 13, 10:13 AM
gerritbot added a comment.Thu, Aug 13, 12:53 PM

Change #1324698 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update PHPat version

https://gerrit.wikimedia.org/r/1324698

gerritbot added a comment.Thu, Aug 13, 12:53 PM

Change #1324708 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update PHPat to latest version

https://gerrit.wikimedia.org/r/1324708

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.16; 2026-08-18).Thu, Aug 13, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Thu, Aug 13, 1:32 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 75) board.Thu, Aug 13, 1:33 PM
Ifrahkhanyaree_WMDE closed this task as Resolved.Wed, Aug 19, 11:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits