Page MenuHomePhabricator

Remove mw.eventLog.eventInSample
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

The mw.eventLog.eventInSample() has been marked as deprecated with mw.log.deprecate(). We should tidy up uses of it and decommission it.

AC

Event Timeline

Change #1306717 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/skins/Vector@master] skins.vector.js: mw.eventLog.eventInSample() -> pageviewInSample()

https://gerrit.wikimedia.org/r/1306717

Change #1306719 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/WikimediaEvents@master] ext.wikimediaEvents: mw.eventLog.eventInSample() -> pageviewInSample()

https://gerrit.wikimedia.org/r/1306719

Change #1306721 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/EventLogging@master] ext.eventLogging: Remove mw.eventLog.eventInSample()

https://gerrit.wikimedia.org/r/1306721

Change #1306717 merged by jenkins-bot:

[mediawiki/skins/Vector@master] skins.vector.js: Remove "Vector ready" metrics

https://gerrit.wikimedia.org/r/1306717

Change #1306719 abandoned by Phuedx:

[mediawiki/extensions/WikimediaEvents@master] ext.wikimediaEvents: mw.eventLog.eventInSample() -> pageviewInSample()

https://gerrit.wikimedia.org/r/1306719

phuedx set the point value for this task to 1.

Change #1306721 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] ext.eventLogging: Remove mw.eventLog.eventInSample()

https://gerrit.wikimedia.org/r/1306721