Page MenuHomePhabricator

Update the password fields to conform with the V1/V2 experiment changes
Closed, ResolvedPublic3 Estimated Story Points

Description

As part of the V2 experiment for Special:Create Account (T422295, which included the changes from the V1 experiment), we made a number of changes to the password field on that page.
This task is about upstreaming these changes into mediawiki core.

Acceptance criteria

  • The GrowthExperiments extension no longer has code modifying the password fields on Special:CreateAccount or Special:UserLogin
  • The adjustments that were made during the experiment to these fields for the treatment group are now available in MediaWiki core as the default experience.
  • The following aspects should be verified as working as expected:
    • Special:Create Account, Special:UserLogin
    • visiting/using these pages as anonymous, temporary, or named user
    • visiting/using these pages both on desktop (=Vector2022) and on mobile (=Minerva)
    • when logged-in: checking the check-box that says "Use a temporary random password and send it to the specified email address"

Event Timeline

KStoller-WMF set the point value for this task to 3.

Change #1309224 had a related patch set uploaded (by EMcFarland; author: EMcFarland):

[mediawiki/extensions/WikimediaEvents@master] CreateAccountForm: Make v2/v2 account creation form changes to the password field the default experience

https://gerrit.wikimedia.org/r/1309224

Change #1309225 had a related patch set uploaded (by EMcFarland; author: EMcFarland):

[mediawiki/extensions/GrowthExperiments@master] CreateAccountForm: Make v1/v2 account creation form changes to the password field the default experience

https://gerrit.wikimedia.org/r/1309225

Change #1309220 had a related patch set uploaded (by EMcFarland; author: EMcFarland):

[mediawiki/core@master] CreateAccountForm: Make v1/v2 account creation form changes to the password field the default experience

https://gerrit.wikimedia.org/r/1309220

Change #1309225 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] CreateAccountForm: Make v1/v2 account creation form changes to the password field the default experience

https://gerrit.wikimedia.org/r/1309225

Change #1309224 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] CreateAccountForm: Make v1/v2 account creation form changes to the password field the default experience

https://gerrit.wikimedia.org/r/1309224

Change #1309220 merged by jenkins-bot:

[mediawiki/core@master] CreateAccountForm: Make v1/v2 account creation form changes to the password field the default experience

https://gerrit.wikimedia.org/r/1309220

@EMcFarland-WMF - a super minor issue: when the warning about invalid password is displayed, the eye icon is still visible (and functioning). Do you think it's worth to address it? I did not find any other instances of that issue, i.e. "Confirm password" field seems ok.

Screenshot 2026-07-15 at 5.59.57 PM.png (579×568 px, 62 KB)
Screenshot 2026-07-15 at 6.24.56 PM.png (918×488 px, 41 KB)
Etonkovidova updated the task description. (Show Details)
  • when logged-in: checking the check-box that says "Use a temporary random password and send it to the specified email address"

The check-box "Use a temporary random password and send it to the specified email address" is displayed only when a logged-in user goes to Special:CreateAccount page.

@EMcFarland-WMF - a super minor issue: when the warning about invalid password is displayed, the eye icon is still visible (and functioning). Do you think it's worth to address it? I did not find any other instances of that issue, i.e. "Confirm password" field seems ok.

Thank you for pointing out this minor issue. I will defer to design on whether we should address this. @AAlhazwani-WMF what do you think?

Hi @EAlbizzati-WMF, did you mean to link your pull request to phabricator task?

@EMcFarland-WMF - a super minor issue: when the warning about invalid password is displayed, the eye icon is still visible (and functioning). Do you think it's worth to address it? I did not find any other instances of that issue, i.e. "Confirm password" field seems ok.

Thank you for pointing out this minor issue. I will defer to design on whether we should address this. @AAlhazwani-WMF what do you think?

apologies for the belated reply. @EMcFarland-WMF this is not minor, we should defintely fix this. is this an issue related to the codex component or specifically to the account creation form? is the issue present also in the scenario where we don't display errors as "block" message but as "inline" message? you can check the inline warning/error messages on T424979

@EMcFarland-WMF - a super minor issue: when the warning about invalid password is displayed, the eye icon is still visible (and functioning). Do you think it's worth to address it? I did not find any other instances of that issue, i.e. "Confirm password" field seems ok.

Thank you for pointing out this minor issue. I will defer to design on whether we should address this. @AAlhazwani-WMF what do you think?

apologies for the belated reply. @EMcFarland-WMF this is not minor, we should defintely fix this. is this an issue related to the codex component or specifically to the account creation form? is the issue present also in the scenario where we don't display errors as "block" message but as "inline" message? you can check the inline warning/error messages on T424979

Note: this should be fixed by now, by virtue of the change that did all adjustment for error/warning messages being merged. This should be verifiable on https://test.wikipedia.org/wiki/Special:CreateAccount and later today on enwiki.

@AAlhazwani-WMF and @Michael sorry it was a typo. task was completely unrelated to this one.
updated the PR.
I'm sorry for the noise

To second what Michael said, the issue that Elena found has been fixed.

DMburugu closed this task as Resolved.EditedMon, Jul 27, 10:12 AM

I'll close this based on the fact that it meets the Acceptance Criteria defined and the QS lead has confirmed the issue as fixed. Any issues can be filled as a follow up task.