Page MenuHomePhabricator

Icon only ULS button has incorrect spacing
Open, Needs TriagePublic

Description

Background

Language button is an icon only button on talk pages, and doesnt have the correct button padding. There is also missing spacing between the adjacent add topic button

Screenshot 2026-06-30 at 12.13.14 PM.png (370×156 px, 12 KB)

Go to https://test.wikipedia.org/w/index.php?title=Talk:ApiTestEdit2&action=edit&redlink=1 to see the bug

The button should be similar to the user links button, and be consistent with codex styles

Screenshot 2026-06-30 at 12.15.00 PM.png (208×148 px, 9 KB)

User story

As a user I expect buttons to be consistent across the UI

Acceptance criteria

  • ULS buttons are consistent with codex styles (i.e. roughly 6px horizontal padding)
  • ULS button shouldnt rely on hardcoded CSS

Rollback plan

  • this shouldnt require codex changes, it should just be a single revertable patch

Event Timeline

I think this code is actually in the Vector skin, not in ULS.

I think this code is actually in the Vector skin, not in ULS.

Yes, agreed. This came up previously in T403816.

Note: the solution for that task could be improved by making the horizontal padding exactly match that of Codex Buttons, which subtract the width of the border from the desired padding (that gives us the exact horizontal spacing as designed). So instead of:

padding: 0 @spacing-35;

@media ( max-width: @max-width-breakpoint-tablet ) {
    padding: 0 @spacing-75;
}

we should do this (we can bikeshed which variable to use, see https://doc.wikimedia.org/codex/latest/design-tokens/spacing.html):

padding: 0 @spacing-horizontal-button-icon-only;

@media ( max-width: @max-width-breakpoint-tablet ) {
    padding: 0 @spacing-horizontal-button;
}