| neriah | |
| Jun 30 2026, 6:08 PM |
| F91279991: image.png | |
| Jun 30 2026, 6:08 PM |
| F91279574: Screenshot 2026-06-30 204944.png | |
| Jun 30 2026, 6:08 PM |
Steps to replicate the issue:
What happens?:
Since no permissions were added in this log entry, the granted field is displayed and is empty
What should have happened instead?:
If no permissions were granted, the granted field should not be displayed at all...
Other information:
Interestingly, the log is displayed correctly on meta:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| RightsLogFormatter: Handle weird backfilled log entries | Bartosz Dziewoński | mediawiki/core | master | +45 -6 |
The parameters stored for this log entry are unusual:
mysql:research@dbstore1008.eqiad.wmnet [hewiki]> select log_params from logging where log_id=19665620;
a:2:{s:12:"4::oldgroups";a:1:{i:0;s:5:"sysop";}s:12:"5::newgroups";a:1:{i:0;s:0:"";}}php > var_dump( unserialize( 'a:2:{s:12:"4::oldgroups";a:1:{i:0;s:5:"sysop";}s:12:"5::newgroups";a:1:{i:0;s:0:"";}}' ) );
array(2) {
["4::oldgroups"]=>
array(1) {
[0]=>
string(5) "sysop"
}
["5::newgroups"]=>
array(1) {
[0]=>
string(0) ""
}
}So newgroups is an array containing the empty string ([ "" ]).
We have code to handle old log entries where newgroups (or oldgroups) is just an empty string, but not that: https://gerrit.wikimedia.org/g/mediawiki/core/+/cc27c177c72edacbc6ef88e222dfe25753d3d3ee/includes/Logging/RightsLogFormatter.php#477
Ah, this was recently backfilled: T6055 and I guess it's a bug in the script used for that. We can handle this when displaying.
Change #1307835 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/core@master] RightsLogFormatter: Handle weird backfilled log entries
Change #1307835 merged by jenkins-bot:
[mediawiki/core@master] RightsLogFormatter: Handle weird backfilled log entries