Description
After some work regarding GrowthBook Integration + Customization, the new Test Kitchen poller is running two different validation processes:
- When the experiment is still a draft, a reduced validation process is done as a way to auto-complete the Pre-Launch Checklist items. That helps experiment owners to review their experiments once they have been registered and before starting/activating them. Here, only the rules that have a corresponding item in the Checklist are validated.
- Once an experiment has been started/activated, and before being added to experiment_cache to be considered by Test Kitchen API, there is a full validation process that checks that everything is properly configured. If something fails, the experiments will be drafted.
And during the review of T429420: [Customize GrowthBook] Auto-check Pre-Launch Checklist items via the backend poller we realized that we could have extended the Pre-Launch Checklist. There are some validation rules that can fail but there is no a corresponding item in the Checklist. Having those items there would help experiment owners while they are reviewing their experiments before activating them. Others, for example stream_name, have limited possible values and wouldn't make sense to have a related item in the Checklist. And others like risk_level being set as Risk assessment pending would be ok, at that time, because the experiment is still a draft when running the Checklist validation process.
Acceptance criteria
- Pre-Launch Checklist has been extended with new items related to the following validation rules:
- Dates validation (Friday deployment are not allowed)
- Wikis validation, specifically the Invalid wiki IDs validation error (the wiki count one has already an item in the Checklist)
- Validation for the new items added above runs also for Experiment Drafts to complete the corresponding items