Page MenuHomePhabricator

Align validation rules of running and draft experiments
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

After some work regarding GrowthBook Integration + Customization, the new Test Kitchen poller is running two different validation processes:

  • When the experiment is still a draft, a reduced validation process is done as a way to auto-complete the Pre-Launch Checklist items. That helps experiment owners to review their experiments once they have been registered and before starting/activating them. Here, only the rules that have a corresponding item in the Checklist are validated.
  • Once an experiment has been started/activated, and before being added to experiment_cache to be considered by Test Kitchen API, there is a full validation process that checks that everything is properly configured. If something fails, the experiments will be drafted.

And during the review of T429420: [Customize GrowthBook] Auto-check Pre-Launch Checklist items via the backend poller we realized that we could have extended the Pre-Launch Checklist. There are some validation rules that can fail but there is no a corresponding item in the Checklist. Having those items there would help experiment owners while they are reviewing their experiments before activating them. Others, for example stream_name, have limited possible values and wouldn't make sense to have a related item in the Checklist. And others like risk_level being set as Risk assessment pending would be ok, at that time, because the experiment is still a draft when running the Checklist validation process.

Acceptance criteria

  • Pre-Launch Checklist has been extended with new items related to the following validation rules:
    • Dates validation (Friday deployment are not allowed)
    • Wikis validation, specifically the Invalid wiki IDs validation error (the wiki count one has already an item in the Checklist)
  • Validation for the new items added above runs also for Experiment Drafts to complete the corresponding items

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
New Checklist items are completed according validation processrepos/data-engineering/test-kitchen!365sfaciT430842/align-validation-processesmain
Customize query in GitLab

Event Timeline

Sfaci set the point value for this task to 2.

Change #1309221 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/deployment-charts@master] Test Kitchen UI: Deploy v1.4.7 release to staging

https://gerrit.wikimedia.org/r/1309221

Change #1309221 merged by jenkins-bot:

[operations/deployment-charts@master] Test Kitchen UI: Deploy v1.4.7 release to staging

https://gerrit.wikimedia.org/r/1309221

Change #1310139 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] Test Kitchen UI: Deploying v1.4.8 release to production

https://gerrit.wikimedia.org/r/1310139

Change #1310139 merged by jenkins-bot:

[operations/deployment-charts@master] Test Kitchen UI: Deploying v1.4.8 release to production

https://gerrit.wikimedia.org/r/1310139