Page MenuHomePhabricator

PHP Deprecated: Use of MediaWiki\Skin\SkinTemplate::injectLegacyMenusIntoPersonalTools was deprecated in Please make sure Skin option menus contains `user-menu` (and possibly `notifications`, `user-interface-preferences`, `user
Open, Needs TriagePublicBUG REPORT

Description

NOTE: Read through and follow migration steps in T416652: Migrate skins to modern menus and drop legacy personal and namespaces menu to address this issue for the associated skin! Thanks in advance!

Steps to replicate the issue (include links if applicable):

  • Install MediaWiki 1.46.0 stable
  • install the skin
  • Observe the deprecation warning in the server logs

What happens?:
Deprecated: Use of MediaWiki\Skin\SkinTemplate::injectLegacyMenusIntoPersonalTools was deprecated in Please make sure Skin option menus contains user-menu (and possibly notifications, user-interface-preferences, user-page) 1.46. [Called from MediaWiki\Skin\SkinTemplate::getPortletsTemplateData in /data/project/skins/public_html/includes/Skin/SkinTemplate.php at line 692] in /data/project/skins/public_html/includes/Debug/MWDebug.php on line 372

What should have happened instead?:
No deprecation warning

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
MediaWiki 1.46.0
Latest REL1_46 for each skin

Event Timeline

Change #1267093 had a related patch set uploaded (by SomeRandomDeveloper; author: Jdlrobson):

[mediawiki/skins/Cosmos@master] Upgrade for 1.46

https://gerrit.wikimedia.org/r/1267093

Change #1307219 had a related patch set uploaded (by MacFan4000; author: Jdlrobson):

[mediawiki/skins/GreyStuff@REL1_46] Fix deprecation warnings for 1.46

https://gerrit.wikimedia.org/r/1307219

Change #1307219 merged by jenkins-bot:

[mediawiki/skins/GreyStuff@REL1_46] Fix deprecation warnings for 1.46

https://gerrit.wikimedia.org/r/1307219

Change #1266489 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Nimbus@master] Migrate to modern menus

https://gerrit.wikimedia.org/r/1266489

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Change #1348756 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/skins/Pivot@master] Migrate Pivot to modern skin menus

https://gerrit.wikimedia.org/r/1348756

Change #1266489 merged by jenkins-bot:

[mediawiki/skins/Nimbus@master] Migrate to modern menus

https://gerrit.wikimedia.org/r/1266489

Change #1348756 merged by jenkins-bot:

[mediawiki/skins/Pivot@master] Migrate Pivot to modern skin menus

https://gerrit.wikimedia.org/r/1348756