Page MenuHomePhabricator

Images loading in dynamic sections even when images disabled
Closed, ResolvedPublic


The summary pretty much says it all. To replicate:

  • Ensure you're in the beta for MobileFrontend
  • Settings -> disable images
  • Load article with sections containing images (eg Barack Obama on enwiki)
  • Click a section header for a section containing images (eg Barack Obama -> Presidential campaigns)
  • Note images loading :(

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:53 AM
bzimport set Reference to bz41091.
bzimport added a subscriber: Unknown Object (MLST).

sumanah wrote:

Is this happening on master?

Yes, it's happening on master (and incidentally currently in production), but only on the beta version of MobileFrontend, which is expected to contain various issues such as this. But this will need to be fixed before being moved out of beta into our normal production.

I guess what needs to happen is this:

  • mwMobileFrontendConfig needs to pass a flag saying that images are disabled
  • calls to the api to grab sections should pass a parameter (I forget what this parameter is) to request the content of sections without images

Should be relatively easy.