Page MenuHomePhabricator

[Task] Tests for PropertyDiff etc need refactoring
Closed, InvalidPublic

Description

PropertyDiffTest and ItemDiffTest should share code in EntityDiffTest.

Please also fix the strict standards warning about an incompatible signature of ItemDiffTest::provideApplyData.

Details

Reference
bz41106

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenFeatureNone
OpenFeatureNone
DuplicateNone
ResolvedNone
ResolvedNone
ResolvedNone
DuplicateNone
InvalidLydia_Pintscher
OpenNone
OpenNone
StalledNone
OpenNone
ResolvedAddshore
Resolvedthiemowmde
ResolvedAddshore
InvalidNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:54 AM
bzimport set Reference to bz41106.
bzimport added a subscriber: Unknown Object (MLST).

Yes, it's stil la mess: ItemDiffTest now extends EntityDiffOldTest, while we also have EntityDiffTest.

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
JanZerebecki renamed this task from Tests for PropertyDiff etc need refactoring to [Task] Tests for PropertyDiff etc need refactoring.Sep 10 2015, 1:29 PM
JanZerebecki added a project: Technical-Debt.
JanZerebecki set Security to None.
JanZerebecki removed a subscriber: Wikidata-bugs.
Addshore subscribed.

These classes and tests no longer exist in their old form.