Page MenuHomePhabricator

star-filled.svg and star-half-filled.svg in timeless are opaque gray instead of translucent black like the other icons
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Look at the svgs on any background that isn't white

What happens?:
The star-filled.svg and star-half-filled.svg are opaque gray instead of translucent black like the other icons.

What should have happened instead?:
They should be consistent with the other icons.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): Timeless 0.9.1 on my wiki and it is in the current version of the skin on the git

Other information (browser name/version, screenshots, etc.):

{60DCE048-C60E-4317-96AE-BC7B794B2666}.png (1,745×801 px, 36 KB)

(converted to png so they display in my file explorer)

Details

Event Timeline

Peter_Samuels updated the task description. (Show Details)
Peter_Samuels updated the task description. (Show Details)
Peter_Samuels updated the task description. (Show Details)
Shreyapedia subscribed.

Hey...I'd like to fix this!

Change #1307337 had a related patch set uploaded (by Shreyapedia; author: Shreyapedia):

[mediawiki/skins/Timeless@master] Fix opaque gray color on star icons (Bug: T431072)

https://gerrit.wikimedia.org/r/1307337

Change #1307337 had a related patch set uploaded (by Bartosz Dziewoński; author: Shreyapedia):

[mediawiki/skins/Timeless@master] Fix opaque gray color on star icons

https://gerrit.wikimedia.org/r/1307337

Change #1307337 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Fix opaque gray color on star icons

https://gerrit.wikimedia.org/r/1307337

matmarex subscribed.

Thanks for the bug report and the patch!