Page MenuHomePhabricator

Fix broken emoji (mojibake) in the Submission Form
Open, LowPublic

Description

The category emojis render as garbage (📗, 📘, 🚫) because of a file-encoding issue.

Files: frontend/src/pages/SubmissionForm.tsx (~lines 279, 291, 304). Grep the repo for other ðŸ occurrences.

Acceptance criteria:

  • Emojis (📗 📘 🚫) display correctly
  • File saved as UTF-8

Event Timeline

Tiisu triaged this task as Low priority.

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

I have read and understood the task. I am working on it and will submit a patch for review shortly.

I have submitted a patch addressing this task.

The patch fixes the broken UTF-8 emoji rendering in the submission form by replacing the corrupted emoji sequences with the correct UTF-8 emojis.

Pull Request: https://github.com/Tiisu/SourceWiki/pull/44

Gkm563 moved this task from Incoming to To review on the RoadToWiki board.

I have submitted a patch addressing this task.

The patch fixes the broken UTF-8 emoji rendering in the submission form by replacing the corrupted emoji sequences with the correct UTF-8 emojis.

Pull Request: https://github.com/Tiisu/SourceWiki/pull/44

I have merged your request

I have merged your request

@Tiisu: Any reason to keep this task open instread of setting the status to resolved?